resolve: Do not skip extern prelude during speculative resolution#55102
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 18, 2018
Merged
resolve: Do not skip extern prelude during speculative resolution#55102bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
This was referenced Oct 15, 2018
petrochenkov
commented
Oct 15, 2018
petrochenkov
added
the
beta-nominated
Contributor
Author
|
I've added beta nomination just in case, since the issue has backward compatibility implications and affects anything using extern prelude and extern prelude is stabilized on beta. |
nikomatsakis
approved these changes
Oct 16, 2018
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 01c694b2dcab6d8d3d58c68d5e64b38309136391 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #54671) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Contributor
Author
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit 350f9a2 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 18, 2018
resolve: Do not skip extern prelude during speculative resolution Fixes rust-lang#54665
bors
added a commit
that referenced
this pull request
Oct 18, 2018
Rollup of 18 pull requests Successful merges: - #54646 (improve documentation on std::thread::sleep) - #54933 (Cleanup the rest of codegen_llvm) - #54964 (Run both lldb and gdb tests) - #55016 (Deduplicate some code and compile-time values around vtables) - #55031 (Improve verify_llvm_ir config option) - #55050 (doc std::fmt: the Python inspiration is already mentioned in precedin…) - #55077 (rustdoc: Use dyn keyword when rendering dynamic traits) - #55080 (Detect if access to localStorage is forbidden by the user's browser) - #55090 (regression test for move out of borrow via pattern) - #55102 (resolve: Do not skip extern prelude during speculative resolution) - #55104 (Add test for #34229) - #55111 ([Rustc Book] Explain --cfg's arguments) - #55122 (Cleanup mir/borrowck) - #55127 (Remove HybridBitSet::dummy) - #55128 (Fix LLVMRustInlineAsmVerify return type mismatch) - #55142 (miri: layout should not affect CTFE checks (outside of validation)) - #55151 (Cleanup nll) - #55161 ([librustdoc] Disable spellcheck for search field)
Contributor
Author
|
@bors p=1 |
Collaborator
Collaborator
|
☔ The latest upstream changes (presumably #55171) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Contributor
|
discussed at compiler team meeting. beta-accepted. |
pnkfelix
added
the
beta-accepted
emilyalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Oct 18, 2018
[beta] Rollup backports Merged and approved: * #54300: Updated RELEASES.md for 1.30.0 * #54939: rustdoc: don't prefer dynamic linking in doc tests * #54671: resolve: Scale back hard-coded extern prelude additions on 2015 edition * #55102: resolve: Do not skip extern prelude during speculative resolution r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54665