Change the ICE from #55223 to a hard error#55262
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 7, 2018
Merged
Conversation
oli-obk
force-pushed
the
dangling_alloc_id_ice
branch
from
4978e7f to
9f0a352
Compare
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Oct 23, 2018
RalfJung
reviewed
Oct 23, 2018
RalfJung
reviewed
Oct 23, 2018
Member
|
@bors r+ |
Collaborator
|
📌 Commit 2d960a5 has been approved by |
bors
added
S-waiting-on-bors
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Oct 23, 2018
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung
estebank
reviewed
Oct 24, 2018
Member
|
@bors r+ (You are playing with fire, this PR is part of a rollup which might not pick up your typo fix. Let's see.^^) |
Collaborator
|
📌 Commit c2463af has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 25, 2018
…lfJung Change the ICE from rust-lang#55223 to a hard error
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 26, 2018
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 27, 2018
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
kennytm
added
S-waiting-on-author
oli-obk
force-pushed
the
dangling_alloc_id_ice
branch
from
599eb12 to
e70b634
Compare
TimNN
added
S-waiting-on-review
Contributor
|
Ping from triage @RalfJung: It looks like this PR is ready to be reviewed again. |
Contributor
Collaborator
|
📌 Commit e70b634 has been approved by |
bors
added
S-waiting-on-bors
Member
|
Ah, sorry for that. GitHub doesn't send emails when you change labels and also not for all kinds of force-pushes, so I had no idea this was waiting for me. |
Collaborator
bors
added a commit
that referenced
this pull request
Nov 6, 2018
Change the ICE from #55223 to a hard error cc @SimonSapin r? @RalfJung fixes #55287
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @SimonSapin
r? @RalfJung
fixes #55287