[beta] Make sure the installed `awscli` is found on macOS.#55823

alexcrichton · 2018-11-09T15:26:18Z

This is a backport of #55573 which...

Closes #55817

rust-highfive · 2018-11-09T15:26:30Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-11-09T15:26:31Z

⚠️ Warning ⚠️

Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

alexcrichton · 2018-11-09T15:26:52Z

@bors: r+ p=100

bors · 2018-11-09T15:26:53Z

📌 Commit bf0aecc has been approved by alexcrichton

bors · 2018-11-09T17:27:04Z

⌛ Testing commit bf0aecc with merge 550bfa43da86f1f6cdb1ee323bef8c8a2db709d0...

bors · 2018-11-09T19:06:19Z

💔 Test failed - status-travis

rust-highfive · 2018-11-09T19:06:19Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:29:46] test test_use_statement_completion_doesnt_suggest_arguments ... ok
[01:29:46] 
[01:29:46] failures:
[01:29:46] 
[01:29:46] ---- cmd_changing_workspace_lib_retains_bin_diagnostics stdout ----
[01:29:46] thread 'cmd_changing_workspace_lib_retains_bin_diagnostics' panicked at 'expected bin error diagnostic', libcore/option.rs:1008:5
[01:29:46] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:29:46] ---rls-stdout---
[01:29:46] 
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":"]},"definitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{"resolveProvider":false},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"renameProvider":true,"executeCommandProvider":{"commands":["rls.applySuggestion-14785","rls.deglobImports-14785"]}}}}Content-Length: 92
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","title":"Building"}}Content-Length: 112
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library","title":"Building"}}Content-Length: 122
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library cfg(test)","title":"Building"}}Content-Length: 111
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"binary","title":"Building"}}Content-Length: 121
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"binary cfg(test)","title":"Building"}}Content-Length: 104
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_1","title":"Building"}}Content-Length: 92
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_0","title":"Indexing"}}Content-Length: 493
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `val`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_val` instead: `_val`","range":{"end":{"character":27,"line":4},"start":{"character":24,"line":4}},"severity":2,"source":"rustc"}],"uri":"file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/rlsit/t0/simple_workspace/binary/src/main.rs"}}Content-Length: 733
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `unused`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_unused` instead: `_unused`","range":{"end":{"character":30,"line":2},"start":{"character":24,"line":2}},"severity":2,"source":"rustc"},{"code":"unused_variables","message":"unused variable: `test_val`\n\nhelp: consider using `_test_val` instead: `_test_val`","range":{"end":{"character":36,"line":9},"start":{"character":28,"line":9}},"severity":2,"source":"rustc"}],"uri":"file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/rlsit/t0/simple_workspace/library/src/lib.rs"}}Content-Length: 104
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_0","title":"Indexing"}}Content-Length: 92
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","title":"Building"}}Content-Length: 122
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"library cfg(test)","title":"Building"}}Content-Length: 112
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"library","title":"Building"}}Content-Length: 121
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"binary cfg(test)","title":"Building"}}Content-Length: 111
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_3","message":"binary","title":"Building"}}Content-Length: 104
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_3","title":"Building"}}Content-Length: 92
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_2","title":"Indexing"}}Content-Length: 444
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"E0425","message":"cannot find function `fetch_u32` in module `library`\n\nnot found in `library`","range":{"end":{"character":53,"line":4},"start":{"character":44,"line":4}},"severity":1,"source":"rustc"}],"uri":"file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/rlsit/t0/simple_workspace/binary/src/main.rs"}}Content-Length: 681
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"E0308","message":"mismatched types\n\nexpected u32, found u64","range":{"end":{"character":62,"line":9},"start":{"character":44,"line":9}},"severity":1,"source":"rustc"},{"code":"unused_variables","message":"unused variable: `unused`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_unused` instead: `_unused`","range":{"end":{"character":30,"line":2},"start":{"character":24,"line":2}},"severity":2,"source":"rustc"}],"uri":"file:///checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/rlsit/t0/simple_workspace/library/src/lib.rs"}}Content-Length: 104
[01:29:46] 
[01:29:46] {"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_2","title":"Indexing"}}
[01:29:46] 
[01:29:46] 
[01:29:46] failures:
[01:29:46]     cmd_changing_workspace_lib_retains_bin_diagnostics
---
travis_time:end:2023e52c:start=1541790328725091780,finish=1541790328735052301,duration=9960521
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01efccd8
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:09e8210f
travis_time:start:09e8210f
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1ca71290
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-11-09T19:08:16Z

@bors: retry

Happened before on last beta pr and... seem spurious?

bors · 2018-11-09T22:10:13Z

⌛ Testing commit bf0aecc with merge 4cba739c72dd444d3758c92acd02c95d406c87f8...

bors · 2018-11-10T01:15:57Z

💔 Test failed - status-appveyor

alexcrichton · 2018-11-10T02:48:27Z

@bors: retry

3 hr timeout

bors · 2018-11-10T04:14:53Z

⌛ Testing commit bf0aecc with merge bee06e3...

[beta] Make sure the installed `awscli` is found on macOS. This is a backport of #55573 which... Closes #55817

bors · 2018-11-10T07:02:59Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bee06e3 to beta...

Make sure the installed awscli is found on macOS.

bf0aecc

rust-highfive assigned nikomatsakis Nov 9, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 9, 2018

alexcrichton mentioned this pull request Nov 9, 2018

Rust Beta not available anymore on macOS #55817

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2018

bors added a commit that referenced this pull request Nov 10, 2018

Auto merge of #55823 - alexcrichton:beta-next, r=alexcrichton

bee06e3

[beta] Make sure the installed `awscli` is found on macOS. This is a backport of #55573 which... Closes #55817

sticnarf mentioned this pull request Nov 10, 2018

Develop sticnarf/yadd#8

Merged

bors merged commit bf0aecc into rust-lang:beta Nov 10, 2018

alexcrichton deleted the beta-next branch November 12, 2018 15:20

Uh oh!

Conversation

alexcrichton commented Nov 9, 2018

Uh oh!

rust-highfive commented Nov 9, 2018

Uh oh!

rust-highfive commented Nov 9, 2018

Uh oh!

alexcrichton commented Nov 9, 2018

Uh oh!

bors commented Nov 9, 2018

Uh oh!

bors commented Nov 9, 2018

Uh oh!

bors commented Nov 9, 2018

Uh oh!

rust-highfive commented Nov 9, 2018

Uh oh!

alexcrichton commented Nov 9, 2018

Uh oh!

bors commented Nov 9, 2018

Uh oh!

bors commented Nov 10, 2018

Uh oh!

alexcrichton commented Nov 10, 2018

Uh oh!

bors commented Nov 10, 2018

Uh oh!

bors commented Nov 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants