resolve: Make "empty import canaries" invisible from other crates#56117
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 21, 2018
Merged
resolve: Make "empty import canaries" invisible from other crates#56117bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
This is a fix for stable-to-beta regression, so I'm going to beta-nominate if it's not too late. r? @eddyb |
petrochenkov
added
the
beta-nominated
Member
|
@bors r+ |
Collaborator
|
📌 Commit 1e4cf74 has been approved by |
bors
added
S-waiting-on-bors
Member
|
@bors: p=1 |
Collaborator
|
⌛ Testing commit 1e4cf74 with merge 01deeb44d6df79efed934b4d7a9e002a3673e9d1... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
Contributor
Author
|
Seems like Travis job just died in the middle of LLVM build. |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Nov 21, 2018
resolve: Make "empty import canaries" invisible from other crates
Empty imports `use prefix::{};` are desugared into `use prefix::{self as _};` to make sure the prefix is checked for privacy/stability/etc.
This caused issues in cross-crate scenarios because gensyms are lost in crate metadata (the `_` is a gensym).
Fixes #55811
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Nov 23, 2018
[beta] Rollup backports * #56163: [master] Backport 1.30.1 release notes * #56147: resolve: Fix some asserts in import validation * #56118: Update books for Rust 2018 * #56117: resolve: Make "empty import canaries" invisible from other crates * #56065: Replace the ICEing on const fn loops with an error * #56143: Issue 56128 segment id ice nightly * #56134: Fix clippy documentation links (first in #56156) r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty imports
use prefix::{};are desugared intouse prefix::{self as _};to make sure the prefix is checked for privacy/stability/etc.This caused issues in cross-crate scenarios because gensyms are lost in crate metadata (the
_is a gensym).Fixes #55811