Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
Copying in the relevant paragraph from the PR @ollie27 linked:
So, i can't accept the parts that enable proc-macro re-export, since (as far as i know) this information still doesn't exist. If that's no longer the case, though, then i'd be happy to take it! There's a brief intro to rustdoc's tests in the rustc guide, otherwise you can take a look at the |
Contributor
Author
I've missed that part. It's now removed. Do you know what needs to be done to get this working? |
Contributor
|
It would involve changing proc-macros in general to be able to save more information between crates than what we currently send. I'm not too familiar with their implementation; maybe someone from @rust-lang/compiler can provide more input? |
QuietMisdreavus
approved these changes
Dec 4, 2018
Contributor
QuietMisdreavus
left a comment
QuietMisdreavus
left a comment
There was a problem hiding this comment.
The rest of this PR looks good, thanks for adding the test!
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 956b03f has been approved by |
bors
added
S-waiting-on-bors
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Dec 6, 2018
…ort, r=QuietMisdreavus Rustdoc inline macro reexport Fixes rust-lang#56173 I assume this needs to have tests? Any pointers where these need to be added?
bors
added a commit
that referenced
this pull request
Dec 6, 2018
Rollup of 11 pull requests Successful merges: - #56315 (Rustdoc inline macro reexport) - #56332 ([rustdoc] Specific crate search) - #56362 (Stabilise exhaustive integer patterns) - #56426 (libsyntax_pos: A few tweaks) - #56441 (rustbuild: Fix issues with compiler docs) - #56446 (pass the parameter environment to `traits::find_associated_item`) - #56500 (cleanup: remove static lifetimes from consts) - #56525 (Avoid extra copy and syscall in std::env::current_exe) - #56528 (Remove unused dependency (rustc_lint -> rustc_mir)) - #56548 (Optimized string FromIterator + Extend impls) - #56553 (Don't print the profiling summary to stdout when -Zprofile-json is set) Failed merges: r? @ghost
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56173
I assume this needs to have tests? Any pointers where these need to be added?