Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit e41e85c has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 4, 2018
…tMisdreavus Fix line numbers display Thanks to @talchas for finding the bug and suggesting the solution! r? @QuietMisdreavus
This was referenced Dec 5, 2018
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 5, 2018
…tMisdreavus Fix line numbers display Thanks to @talchas for finding the bug and suggesting the solution! r? @QuietMisdreavus
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Dec 5, 2018
…tMisdreavus Fix line numbers display Thanks to @talchas for finding the bug and suggesting the solution! r? @QuietMisdreavus
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Dec 5, 2018
…tMisdreavus Fix line numbers display Thanks to @talchas for finding the bug and suggesting the solution! r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Dec 5, 2018
Rollup of 15 pull requests Successful merges: - #51753 (Document `From` implementations) - #55563 (Improve no result found sentence in doc search) - #55987 (Add Weak.ptr_eq) - #56119 (Utilize `?` instead of `return None`.) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56388 (More MIR borrow check cleanup) - #56424 (Mention raw-ident syntax) - #56452 (Remove redundant clones) - #56456 (Handle existential types in dead code analysis) - #56466 (data_structures: remove tuple_slice) - #56476 (Fix invalid line number match) - #56497 (cleanup: remove static lifetimes from consts in libstd) - #56498 (Fix line numbers display) - #56523 (Added a bare-bones eslint config (removing jslint)) - #56538 (Use inner iterator may_have_side_effect for Cloned) Failed merges: r? @ghost
This was referenced Dec 6, 2018
QuietMisdreavus
added
beta-nominated
Contributor
|
@rust-lang/rustdoc Nominating for backport because the issue this solves is on beta and the fix is small. Immediately accepting based on #56720 (comment) |
QuietMisdreavus
added
the
T-rustdoc
emilyalbini
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @talchas for finding the bug and suggesting the solution!
r? @QuietMisdreavus