Conversation
|
@bors r+ |
|
📌 Commit 7b80acea5dc0b845efdcc3acc7f5a7a76551d8c7 has been approved by |
|
Nominating for stable and beta backport, otherwise rustc can't be built from source. |
|
Notice that miri failing to build does not block a release. It is essentially coincidence when a beta is branched off at a time when the miri toolstate was green, and there will likely be releases where miri does not build. I think that's okay, miri is a low-priority nightly-only tool that shouldn't interfere with releases. I am not even sure if the miri in the 1.31 will build. The PR just fixes the vergen problem, which is unrelated to whether the miri version matches rustc. |
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
|
Looking at the build log, backporting to beta makes sense: but backporting to stable does not because miri would not build anyway: |
|
I think we should rather find a way not to build or include |
|
@oli-obk you mean miri? |
|
Rebased. This PR will be a lot of fun. I am taking bets how many rebases will be required ;) @bors r=oli-obk |
|
📌 Commit f2a6db7 has been approved by |
|
Uh, woops, misread the original issue, this is not critical. |
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #56576
r? @oli-obk