fix span for invalid number of parameters in trait method#56641
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 11, 2018
Merged
Conversation
Contributor
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Dec 10, 2018
| ... | ||
| LL | / &mut self, //~ ERROR | ||
| LL | | x: i32, | ||
| | |______________^ expected 3 parameters, found 2 |
Contributor
There was a problem hiding this comment.
I think this could be tweaked to actually include either the fn signature or the entire block in order to provide enough context when generating this error in the terminal, but that would be a good follow up tweak.
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 05cea31 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 10, 2018
…valid-nb-parameters, r=estebank fix span for invalid number of parameters in trait method Fixes rust-lang#56582.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56582.