Stabilize Duration::{as_millis, as_micros, as_nanos}#57124
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 27, 2018
Merged
Stabilize Duration::{as_millis, as_micros, as_nanos}#57124bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
added
the
relnotes
Centril
approved these changes
Dec 25, 2018
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Looks good; I'll r+ when tree-close is over.
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit fc32fbaac44b9f128eadc6716fe9f319d61a2c41 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
sunjay
force-pushed
the
stable_duration_as_u128
branch
from
fc32fba to
1e82618
Compare
Contributor
Author
|
Fixed the merge conflict. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 1e82618 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Dec 26, 2018
Stabilize Duration::{as_millis, as_micros, as_nanos}
Fixes #50202. 🎉
This is the stabilization PR for the `duration_as_u128` feature. I have never made one of these before so please let me know if I missed a step. I followed the [guide in the Rust Forge](https://forge.rust-lang.org/stabilization-guide.html) and also found some old stabilization PRs ([1](#57002), [2](#56207)) for similar features to base my work on.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
Author
|
🎉 |
Centril
added
the
T-libs-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50202. 🎉
This is the stabilization PR for the
duration_as_u128feature. I have never made one of these before so please let me know if I missed a step. I followed the guide in the Rust Forge and also found some old stabilization PRs (1, 2) for similar features to base my work on.