Use platform-dependent mcount function

[quark-zju]

Follow up with @nagisa's comment on #57220. Not all platforms use the
mcount name. Added a test.

[rust-highfive]

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

[nagisa]

This does not seem to cover it.

Looking at clang’s this->MCountName instances:

• darwin uses \01mcount;
• On Aarch64 if abi is gnueabi, \01_mcount is used;
• On ARM-linux or ARM-unknown if abi is gnueabi \01__gnu_mcount_nc is used and \01mcount if not gnueabi;

Please make this a target property (specified in target files) and use that property here.

[nagisa]

(I used github search like this. I’m sure it missed some cases as well)

[petrochenkov]

r? @nagisa

[quark-zju]

Thanks for the comments! I was aware of the other mcount names. I didn't add the \01 prefix as I don't fully understand it - When using objdump on an OSX clang -pg binary, it seems \01 prefix got stripped. The clang test didn't test them either (they probably should).

Meanwhile I'm on vacation and have temporarily lost access to fast network, fast machines, and osx platforms. I'll continue work on this when I regain access.

[namhyung]

I also don't know why the \01 prefix is there. But the gnueabi names should be used when it meets the requirements from the ABI. The mcount function in glibc has two arguments - current and parent function addresses. It's architecture dependent how these info will be passed (and be restored if needed).

Please take a look at below:

https://github.com/torvalds/linux/blob/master/arch/arm/kernel/entry-ftrace.S

The tools using the mcount facility (including uftrace) will expect same stack/register layout from the name.

[nagisa]

I didn't add the \01 prefix as I don't fully understand it - When using objdump on an OSX clang -pg binary, it seems \01 prefix got stripped.

It is usually the case that tools like objdump will demangle the ABI-related symbols.

In any case, I would recommend to just add a target property for now, without worrying about what value would be the most correct for the target. Change only the targets where you’re confident about the difference and leave the other platforms with a default of some sort (e.g. mcount). Target maintainers will end up dealing with it for their target as/if any issues come up.

[Dylan-DPC-zz]

ping from triage @quark-zju any updates?

[quark-zju]

@Dylan-DPC I'm still on vacation. I'll get back to this next week if everything goes well.

[Dylan-DPC-zz]

ping from triage @quark-zju any updates on this?

[Centril]

ping from triage @quark-zju :)

[Dylan-DPC-zz]

ping from triage @quark-zju
Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again! Thanks for taking the time to contribute :)