Add suggestion for incorrect field syntax.#57863

davidtwco · 2019-01-23T16:01:33Z

This commit adds a suggestion when a = character is used when
specifying the value of a field in a struct constructor incorrectly
instead of a : character.

r? @estebank

davidtwco · 2019-01-23T16:04:03Z

Sorry for another addition to your review queue @estebank. Not sure if this is the approach we want to take with this issue or if it is too large a change for the potential gain - if we just want to change to keep the existing error but add : (as below) then I can revisit this and do that:

error: expected one of `:`, `,` or `}`, found `=`

src/libsyntax/parse/parser.rs

estebank · 2019-01-23T20:17:42Z

@bors r+

bors · 2019-01-23T20:17:44Z

📌 Commit 517840b3124c859bdfcd5e3d0ec8666d036dcb9f has been approved by estebank

estebank · 2019-01-23T20:18:12Z

@bors r-

src/libsyntax/parse/parser.rs

davidtwco · 2019-01-23T21:08:04Z

Since only ':' is expected, this should just state "expected :, found =".

I leant toward matching the structure of the existing messages - expected one of X, found Y instead of omitting the "one of". I can change this if we prefer otherwise.

ljedrz · 2019-01-23T21:13:14Z

I just feel this might sound like a piece of the error is missing, but it's not a big deal, especially if this is an existing convention for singular items (in which case it might be a better idea to potentially adjust the convention).

estebank · 2019-01-23T22:31:15Z

Yeah, sorry about that it was my typo, my bad. It should be "expected :, found =", I had originally written "expected one of :, , or }, found =" and chose against that to make it even clearer for this case in particular. Can you change it to that?

This commit adds a suggestion when a `=` character is used when specifying the value of a field in a struct constructor incorrectly instead of a `:` character.

davidtwco · 2019-01-23T22:42:15Z

@estebank should be fixed now.

estebank · 2019-01-23T22:44:41Z

@bors r+

bors · 2019-01-23T22:44:42Z

📌 Commit f14d007 has been approved by estebank

@estebank

Add suggestion for incorrect field syntax. Fixes rust-lang#57684. This commit adds a suggestion when a `=` character is used when specifying the value of a field in a struct constructor incorrectly instead of a `:` character. r? @estebank

@estebank

Add suggestion for incorrect field syntax. Fixes rust-lang#57684. This commit adds a suggestion when a `=` character is used when specifying the value of a field in a struct constructor incorrectly instead of a `:` character. r? @estebank

@ghost

Rollup of 9 pull requests Successful merges: - #57380 (Fix Instant/Duration math precision & associativity on Windows) - #57606 (Get rid of the fake stack frame for reading from constants) - #57803 (Several changes to libunwind for SGX target) - #57846 (rustdoc: fix ICE from loading proc-macro stubs) - #57860 (Add os::fortanix_sgx::ffi module) - #57861 (Don't export table by default in wasm) - #57863 (Add suggestion for incorrect field syntax.) - #57867 (Fix std::future::from_generator documentation) - #57873 (Stabilize no_panic_pow) Failed merges: r? @ghost

rust-highfive assigned estebank Jan 23, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2019

petrochenkov reviewed Jan 23, 2019

View reviewed changes

src/libsyntax/parse/parser.rs Outdated Show resolved Hide resolved

davidtwco force-pushed the issue-57684 branch from 93b7b25 to ef261e0 Compare January 23, 2019 16:23

ljedrz reviewed Jan 23, 2019

View reviewed changes

src/libsyntax/parse/parser.rs Outdated Show resolved Hide resolved

davidtwco force-pushed the issue-57684 branch from ef261e0 to 517840b Compare January 23, 2019 17:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 23, 2019

estebank reviewed Jan 23, 2019

View reviewed changes

src/libsyntax/parse/parser.rs Outdated Show resolved Hide resolved

davidtwco force-pushed the issue-57684 branch from 517840b to ac0d342 Compare January 23, 2019 20:52

Add suggestion for incorrect field syntax.

f14d007

This commit adds a suggestion when a `=` character is used when specifying the value of a field in a struct constructor incorrectly instead of a `:` character.

davidtwco force-pushed the issue-57684 branch from ac0d342 to f14d007 Compare January 23, 2019 22:41

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2019

Centril mentioned this pull request Jan 24, 2019

Rollup of 9 pull requests #57874

Closed

Centril mentioned this pull request Jan 24, 2019

Rollup of 9 pull requests #57879

Merged

bors merged commit f14d007 into rust-lang:master Jan 25, 2019

davidtwco deleted the issue-57684 branch January 25, 2019 10:09

pnkfelix mentioned this pull request Mar 4, 2019

Compiler panic with associated constant #58435

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add suggestion for incorrect field syntax.#57863