Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
taiki-e
force-pushed
the
librustc_mir-2018
branch
from
d6bf8e3 to
6326ef7
Compare
taiki-e
force-pushed
the
librustc_mir-2018
branch
from
6326ef7 to
725af30
Compare
scottmcm
reviewed
Feb 8, 2019
matthewjasper
requested changes
Feb 8, 2019
Contributor
matthewjasper
left a comment
matthewjasper
left a comment
There was a problem hiding this comment.
One nit and then I think that this is good to go.
scottmcm
reviewed
Feb 8, 2019
| let mut file = | ||
| pretty::create_dump_file(infcx.tcx, "regioncx.all.dot", None, "nll", &0, source)?; | ||
| regioncx.dump_graphviz_raw_constraints(&mut file)?; | ||
| }; |
taiki-e
commented
Feb 8, 2019
| use super::promote_consts::{self, Candidate, TempState}; | ||
|
|
||
| bitflags! { | ||
| bitflags::bitflags! { |
Member
Author
There was a problem hiding this comment.
bitflags! is only used here.
matthewjasper
approved these changes
Feb 8, 2019
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit c9bc85e has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 8, 2019
…wjasper librustc_mir => 2018 Transitions `librustc_mir` to Rust 2018; cc rust-lang#58099 TODO: ~~elided_lifetimes_in_paths~~ r? @Centril
bors
added a commit
that referenced
this pull request
Feb 9, 2019
Rollup of 18 pull requests Successful merges: - #58091 (Transition compiletest to Rust 2018) - #58115 (Transition rustdoc to 2018 edition) - #58120 (Transition build_helper to 2018 edition) - #58222 (librustc_allocator => 2018) - #58233 (librustc_save_analysis => 2018) - #58245 (librustc_lint => 2018) - #58247 (librustc_passes => 2018) - #58251 (Transition librustc_traits to 2018 edition) - #58255 (librustc_metadata => 2018) - #58256 (librustc_cratesio_shim => 2018) - #58257 (librustc_target => 2018) - #58259 (librustc_codegen_utils => 2018) - #58260 (librustc_borrowck => 2018) - #58261 (librustc_incremental => 2018) - #58265 (librustc_mir => 2018) - #58275 (libcore, liballoc: disable tests in Miri) - #58285 (error_index_generator => 2018) - #58312 (librustc_data_structures => 2018) Failed merges: r? @ghost
78 tasks
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 12, 2019
Revert removed #![feature(nll)] In PRs related to rust-lang#58099, `#![feature(nll)]` was removed from several crates. This PR reverts it. Related: rust-lang#58265 (comment) cc @Centril r? @matthewjasper
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
Revert removed #![feature(nll)] In PRs related to #58099, `#![feature(nll)]` was removed from several crates. This PR reverts it. Related: rust-lang/rust#58265 (comment) cc @Centril r? @matthewjasper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitions
librustc_mirto Rust 2018; cc #58099TODO:
elided_lifetimes_in_pathsr? @Centril