Conversation
rust-highfive
added
the
S-waiting-on-review
|
@scottmcm Can you review this, or should I ask someone to do instead of you? |
|
I don't think it fixes mentioned issue. It upgrades dependency for one package but Rust will still build 3 versions of rand: Lines 4179 to 4181 in 939a263 |
|
Well, this issue is about "Building stage0 compiler artifacts", I think. I checked build log |
|
The title "rustc is using three versions of rand" remains true when this PR is merged. I'm not reviewer but IMO this PR should only |
|
@mati865 Okay, I got it! I changed description following your opinion. Or, should I work on this issue more? |
|
I don't see other problems here. For the further work: I have no idea if upgrading it won't break tools build. It should be however possible to get rid of |
|
Thanks, @JohnTitor! @bors r+ rollup FWIW, I'd be happy for #57724 to close if |
|
📌 Commit 939a263 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup- This PR changes Cargo.lock. |
| "graphviz 0.0.0", | ||
| "log 0.4.6 (registry+https://github.com/rust-lang/crates.io-index)", | ||
| "rand 0.5.5 (registry+https://github.com/rust-lang/crates.io-index)", | ||
| "rand 0.6.1 (registry+https://github.com/rust-lang/crates.io-index)", |
There was a problem hiding this comment.
Any chance of going to 0.6.5 instead? IIUC, that should bring in rand_os 0.1.3, which fixes SIGSYS crashes on illumos.
There was a problem hiding this comment.
I cannot decide that on my own, what do you think @scottmcm? (I updated from 0.6.1 to 0.6.5 on local, but the build was failed.)
There was a problem hiding this comment.
I don't even really know how rand is used, so I have no idea what gotchas might exist, nor do I have strong feeling about which version should be used (just that ideally there'd be only one).
There was a problem hiding this comment.
@JohnTitor do you have error message from that build?
There was a problem hiding this comment.
@mati865 Yes, the message is here:
error[E0463]: can't find crate for `core`=============> ] 16/22: libc
--> C:\Users\username\.cargo\registry\src\github.com-1ecc6299db9ec823\libc-0.2.46\src\lib.rs:161:1
|
161 | extern crate std as core;
| ^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
error: aborting due to previous error
For more information about this error, try `rustc --explain E0463`.
error: Could not compile `libc`.
I updated rand 0.6.1 by cargo update -p rand:0.6.1 and changed this line to 0.6.
There was a problem hiding this comment.
Looks like std failed to build, either it's issue with cache/incremental compilation or something really bad happened.
Update rand version cc: rust-lang#57724 r? @scottmcm
Rollup of 16 pull requests Successful merges: - #58829 (librustc_interface: Update scoped-tls to 1.0) - #58876 (Parse lifetimes that start with a number and give specific error) - #58908 (Update rand version) - #58998 (Fix documentation of from_ne_bytes and from_le_bytes) - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std) - #59057 (Standardize `Range*` documentation) - #59080 (Fix incorrect links in librustc_codegen_llvm documentation) - #59083 (Fix #54822 and associated faulty tests) - #59093 (Remove precompute_in_scope_traits_hashes) - #59101 (Reduces Code Repetitions like `!n >> amt`) - #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!) - #59124 (Replace assert with assert_eq) - #59129 (Visit impl Trait for dead_code lint) - #59130 (Note that NonNull does not launder shared references for mutation) - #59132 (ignore higher-ranked object bound conditions created by WF) - #59138 (Simplify Iterator::{min, max}) Failed merges: r? @ghost
7 participants
cc: #57724
r? @scottmcm