Better diagnostic for binary operation on BoxedValues#59467
Better diagnostic for binary operation on BoxedValues#59467bors merged 2 commits intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
Couple of minor nitpicks, but otherwise r=me
| | ^^^^^ | ||
| | | | ||
| | Error | ||
| | Error |
There was a problem hiding this comment.
Can you add a check for the case when both left and right overlap to avoid this output?
There was a problem hiding this comment.
This is fixed
src/test/ui/span/issue-39018.stderr
Outdated
| | | | | ||
| | | &str | ||
| | &str | ||
| | `+` can't be used to concatenate two `&str` strings |
There was a problem hiding this comment.
Can you change the span for the explanation to use the span pointing at the operator?
There was a problem hiding this comment.
I think this is fixed? Not sure if issue-47380.stderr looks right though
…tion to point at operator
|
@bors r+ rollup |
|
📌 Commit 4644c3a has been approved by |
bors
added
S-waiting-on-bors
…bank Better diagnostic for binary operation on BoxedValues Fixes rust-lang#59458
Rollup of 9 pull requests Successful merges: - #59366 (Update books) - #59436 (Update jemalloc-sys to version 0.3.0) - #59454 (Update rustfmt to 1.2.0) - #59462 (Fix error in Rust 2018 + no_core environment) - #59467 (Better diagnostic for binary operation on BoxedValues) - #59473 (Do not emit incorrect borrow suggestion involving macros and fix overlapping multiline spans) - #59480 (Update stdsimd) - #59486 (Visit `ImplItem` in `dead_code` lint) - #59510 (Rename `type_parameters` to `generics` and so on) Failed merges: - #59516 (Update cargo) r? @ghost
Rollup of 9 pull requests Successful merges: - #59366 (Update books) - #59436 (Update jemalloc-sys to version 0.3.0) - #59454 (Update rustfmt to 1.2.0) - #59462 (Fix error in Rust 2018 + no_core environment) - #59467 (Better diagnostic for binary operation on BoxedValues) - #59473 (Do not emit incorrect borrow suggestion involving macros and fix overlapping multiline spans) - #59480 (Update stdsimd) - #59486 (Visit `ImplItem` in `dead_code` lint) - #59510 (Rename `type_parameters` to `generics` and so on) Failed merges: - #59516 (Update cargo) r? @ghost
4 participants
Fixes #59458