Suggest appropriate path when calling associated item on bare types#60045

estebank · 2019-04-17T17:29:30Z

When looking at the documentation for std::f32 or std::str, for
example, it is easy to get confused and assume std::f32 and f32
are the same thing. Because of this, it is not uncommon to attempt
writing f32::consts::PI instead of the correct
std::f32::consts::PI. When encountering the former, which results
in an access error due to it being an inexistent path, try to access
the same path under std. If this succeeds, this information is
stored for later tweaking of the final E0599 to provide an
appropriate suggestion.

Fix #26760, fix #46660.

rust-highfive · 2019-04-17T17:29:34Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc/session/mod.rs

src/librustc_resolve/lib.rs

petrochenkov · 2019-04-18T14:06:41Z

r? @petrochenkov

petrochenkov · 2019-04-18T20:23:44Z

src/librustc_resolve/lib.rs

if let can be used here

petrochenkov · 2019-04-18T20:25:22Z

Could you revert the changes to resolve_qpath(_anywhere) and squash the commits to avoid the changing/reverting back and forth?

r=me after that

estebank · 2019-04-18T21:27:15Z

@petrochenkov is it ok if I leave the reformatting of signatures to the current style?

petrochenkov · 2019-04-18T21:29:26Z

Rustfmt is going to do that anyway, but yeah, it's probably ok to leave them.

estebank · 2019-04-18T23:52:09Z

@bors r=petrochenkov

bors · 2019-04-18T23:52:10Z

📌 Commit 94e5ec1 has been approved by petrochenkov

Suggest appropriate path when calling associated item on bare types When looking at the documentation for `std::f32` or `std::str`, for example, it is easy to get confused and assume `std::f32` and `f32` are the same thing. Because of this, it is not uncommon to attempt writing `f32::consts::PI` instead of the correct `std::f32::consts::PI`. When encountering the former, which results in an access error due to it being an inexistent path, try to access the same path under `std`. If this succeeds, this information is stored for later tweaking of the final E0599 to provide an appropriate suggestion. Fix rust-lang#26760, fix rust-lang#46660.

Centril · 2019-04-19T01:36:52Z

Failed in #60100 (comment), @bors r-

When looking at the documentation for `std::f32` or `std::str`, for example, it is easy to get confused and assume `std::f32` and `f32` are the same thing. Because of this, it is not uncommon to attempt writing `f32::consts::PI` instead of the correct `std::f32::consts::PI`. When encountering the former, which results in an access error due to it being an inexistent path, try to access the same path under `std`. If this succeeds, this information is stored for later tweaking of the final E0599 to provide an appropriate suggestion. This suggestion applies to both E0233 and E0599 and is only checked when the first ident of a path corresponds to a primitive type.

estebank · 2019-04-19T02:18:45Z

@bors r=petrochenkov rebased

bors · 2019-04-19T02:18:46Z

📌 Commit 6aa4c99 has been approved by petrochenkov

Suggest appropriate path when calling associated item on bare types When looking at the documentation for `std::f32` or `std::str`, for example, it is easy to get confused and assume `std::f32` and `f32` are the same thing. Because of this, it is not uncommon to attempt writing `f32::consts::PI` instead of the correct `std::f32::consts::PI`. When encountering the former, which results in an access error due to it being an inexistent path, try to access the same path under `std`. If this succeeds, this information is stored for later tweaking of the final E0599 to provide an appropriate suggestion. Fix rust-lang#26760, fix rust-lang#46660.

@ghost

Rollup of 16 pull requests Successful merges: - #59915 (Implement event filtering for self-profiler.) - #59933 (Make clear that format padding doesn't work for Debug) - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate) - #60032 (Remove unwanted z-index change) - #60041 (Simplify the returning of a Result a bit) - #60045 (Suggest appropriate path when calling associated item on bare types) - #60052 (Correct unused parameter diagnostic) - #60056 (Update rustfmt to 1.2.1) - #60060 (whitelist RTM x86 target cpu feature) - #60061 (Change suggestion of field when not in self context) - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code) - #60078 (Use more realistic example for thread builder) - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.) - #60082 (Update miri) - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8) - #60098 (libcore: deny `elided_lifetimes_in_paths`) Failed merges: r? @ghost

bors · 2019-04-19T07:03:01Z

⌛ Testing commit 6aa4c99 with merge 316a391...

rust-highfive assigned varkor Apr 17, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2019

This comment has been minimized.

Sign in to view

petrochenkov self-assigned this Apr 17, 2019

This comment has been minimized.

Sign in to view

petrochenkov reviewed Apr 18, 2019

View reviewed changes

src/librustc/session/mod.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Apr 18, 2019

View reviewed changes

src/librustc_resolve/lib.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Apr 18, 2019

View reviewed changes

src/librustc_resolve/lib.rs Outdated Show resolved Hide resolved

petrochenkov reviewed Apr 18, 2019

View reviewed changes

src/librustc_resolve/lib.rs Outdated Show resolved Hide resolved

rust-highfive unassigned varkor Apr 18, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019

estebank force-pushed the suggest-std branch from f11d9ea to 654e0cd Compare April 18, 2019 18:57

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2019

This comment has been minimized.

Sign in to view

estebank force-pushed the suggest-std branch from 654e0cd to 1ac99a7 Compare April 18, 2019 20:21

petrochenkov reviewed Apr 18, 2019

View reviewed changes

src/librustc_resolve/lib.rs Outdated

Copy link

Contributor

petrochenkov Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if let can be used here

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019

estebank force-pushed the suggest-std branch from 1ac99a7 to 94e5ec1 Compare April 18, 2019 21:36

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 18, 2019

Centril mentioned this pull request Apr 19, 2019

Rollup of 16 pull requests #60099

Closed

Centril mentioned this pull request Apr 19, 2019

Rollup of 17 pull requests #60100

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2019

estebank force-pushed the suggest-std branch from 94e5ec1 to 6aa4c99 Compare April 19, 2019 02:18

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 19, 2019

Centril mentioned this pull request Apr 19, 2019

Rollup of 16 pull requests #60104

Merged

bors merged commit 6aa4c99 into rust-lang:master Apr 19, 2019

estebank mentioned this pull request Jul 12, 2019

Deprecate stdlib modules dedicated to numeric constants and move those constants to associated consts rust-lang/rfcs#2700

Merged

Uh oh!

Conversation

estebank commented Apr 17, 2019

Uh oh!

rust-highfive commented Apr 17, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Apr 18, 2019

Uh oh!

This comment has been minimized.

petrochenkov Apr 18, 2019

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented Apr 18, 2019

Uh oh!

estebank commented Apr 18, 2019

Uh oh!

petrochenkov commented Apr 18, 2019

Uh oh!

estebank commented Apr 18, 2019

Uh oh!

bors commented Apr 18, 2019

Uh oh!

Centril commented Apr 19, 2019

Uh oh!

estebank commented Apr 19, 2019

Uh oh!

bors commented Apr 19, 2019

Uh oh!

bors commented Apr 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants