Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Apr 26, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
This applies generally in various places in the file.
ljedrz
force-pushed
the
remove_LoweredNodeId
branch
from
b97eb16 to
c95fd35
Compare
Centril
reviewed
Apr 26, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Some more cases... more generally, search for let hir_id = self.lower_node_id(
ljedrz
force-pushed
the
remove_LoweredNodeId
branch
from
c95fd35 to
83d6c40
Compare
Contributor
Author
|
@Centril This time I think I even got some you haven't noticed yet 😉 . |
Contributor
|
@ljedrz Yea; nice work :) -- I think you caught 'em all. |
Zoxc
reviewed
Apr 28, 2019
Zoxc
reviewed
Apr 28, 2019
ljedrz
force-pushed
the
remove_LoweredNodeId
branch
from
83d6c40 to
d536ec4
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit d536ec4 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 29, 2019
hir: remove LoweredNodeId It seems that we no longer need it, because nowadays we just want the `HirId` most of the time.
bors
added a commit
that referenced
this pull request
Apr 29, 2019
Rollup of 9 pull requests Successful merges: - #59946 (Fix equivalent string in escape_default docs) - #60256 (Option::flatten) - #60305 (hir: remove LoweredNodeId) - #60334 (Stabilized vectored IO) - #60353 (Add test not to forget resolved ICE) - #60356 (Stabilize str::as_mut_ptr) - #60358 (Clarify the short explanation of E0207) - #60359 (resolve: Consider erroneous imports used to avoid duplicate diagnostics) - #60360 (Add test case for labeled break in const assignment) Failed merges: r? @ghost
Collaborator
|
☔ The latest upstream changes (presumably #60377) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that we no longer need it, because nowadays we just want the
HirIdmost of the time.