Make "Implementations on Foreign Types" items in sidebar link to specific impls#60307

dima74 · 2019-04-26T14:24:45Z

This solves #56018 for most cases (though not work for foreign impls with same names)

rust-highfive · 2019-04-26T14:24:55Z

(rust_highfive has picked a reviewer for you, use r? to override)

GuillaumeGomez · 2019-04-26T15:29:04Z

Thanks! Please add tests.

rust-highfive · 2019-04-26T16:01:18Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:35e00c32:start=1556288750291620017,finish=1556288752783072256,duration=2491452239
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:26:12] 
[01:26:12] running 9 tests
[01:26:12] iiiiiiiii
[01:26:12] 
[01:26:12]  finished in 0.152
[01:26:12] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:26:28] 
[01:26:28] running 121 tests
[01:26:54] .iiiii...i.....i..i...i..i.i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i. 100/121
[01:26:58] i.i......iii.i.....ii
[01:26:58] 
[01:26:58]  finished in 29.807
[01:26:58] travis_fold:end:test_debuginfo

---
travis_time:start:test_rustdoc
Check compiletest suite=rustdoc mode=rustdoc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:31:26] 
[01:31:26] running 304 tests
[01:32:46] .........F..................i...............................F...F................................... 100/304
[01:33:54] ...........................................i........F............................................... 200/304
[01:35:06] ....................................F............................................................... 300/304
[01:35:08] failures:
[01:35:08] 
[01:35:08] ---- [rustdoc] rustdoc/blanket-reexport-item.rs stdout ----
[01:35:08] 
[01:35:08] 
[01:35:08] error: htmldocck failed!
[01:35:08] status: exit code: 1
[01:35:08] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/blanket-reexport-item" "/checkout/src/test/rustdoc/blanket-reexport-item.rs"
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] stderr:
[01:35:08] stderr:
[01:35:08] ------------------------------------------
[01:35:08] 3: @has check failed
[01:35:08]  `XPATH PATTERN` did not match
[01:35:08]  // @has foo/struct.S.html '//h3[@id="impl-Into"]//code' 'impl<T, U> Into for T'
[01:35:08] Encountered 1 errors
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] 
[01:35:08] 
[01:35:08] ---- [rustdoc] rustdoc/generic-impl.rs stdout ----
[01:35:08] 
[01:35:08] error: htmldocck failed!
[01:35:08] status: exit code: 1
[01:35:08] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/generic-impl" "/checkout/src/test/rustdoc/generic-impl.rs"
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] stderr:
[01:35:08] stderr:
[01:35:08] ------------------------------------------
[01:35:08] 8: @has check failed
[01:35:08]  `XPATH PATTERN` did not match
[01:35:08]  // @has foo/struct.Foo.html '//h3[@id="impl-ToString"]//code' 'impl<T> ToString for T'
[01:35:08] Encountered 1 errors
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] 
[01:35:08] 
[01:35:08] ---- [rustdoc] rustdoc/hidden-trait-struct-impls.rs stdout ----
[01:35:08] 
[01:35:08] error: htmldocck failed!
[01:35:08] status: exit code: 1
[01:35:08] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/hidden-trait-struct-impls" "/checkout/src/test/rustdoc/hidden-trait-struct-impls.rs"
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] stderr:
[01:35:08] stderr:
[01:35:08] ------------------------------------------
[01:35:08] 18: @has check failed
[01:35:08]  `XPATH PATTERN` did not match
[01:35:08]  // @has foo/struct.Bar.html '//*[@id="impl-Bam"]' 'impl Bam for Bar'
[01:35:08] Encountered 1 errors
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] 
[01:35:08] 
[01:35:08] ---- [rustdoc] rustdoc/issue-29503.rs stdout ----
[01:35:08] 
[01:35:08] error: htmldocck failed!
[01:35:08] status: exit code: 1
[01:35:08] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/issue-29503" "/checkout/src/test/rustdoc/issue-29503.rs"
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] stderr:
[01:35:08] stderr:
[01:35:08] ------------------------------------------
[01:35:08] 10: @has check failed
[01:35:08]  `XPATH PATTERN` did not match
[01:35:08]  // @has - "//div[@id='implementors-list']/h3[@id='impl-MyTrait']//code" "impl<T> MyTrait for T where T: Debug"
[01:35:08] Encountered 1 errors
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] 
[01:35:08] 
[01:35:08] ---- [rustdoc] rustdoc/primitive-generic-impl.rs stdout ----
[01:35:08] 
[01:35:08] error: htmldocck failed!
[01:35:08] status: exit code: 1
[01:35:08] command: "/usr/bin/python2.7" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc/primitive-generic-impl" "/checkout/src/test/rustdoc/primitive-generic-impl.rs"
[01:35:08] ------------------------------------------
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] stderr:
[01:35:08] stderr:
[01:35:08] ------------------------------------------
[01:35:08] 5: @has check failed
[01:35:08]  `XPATH PATTERN` did not match
[01:35:08]  // @has foo/primitive.i32.html '//h3[@id="impl-ToString"]//code' 'impl<T> ToString for T'
[01:35:08] Encountered 1 errors
[01:35:08] 
[01:35:08] ------------------------------------------
[01:35:08] 
---
[01:35:08] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:517:22
[01:35:08] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:35:08] 
[01:35:08] 
[01:35:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:35:08] 
[01:35:08] 
[01:35:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:35:08] Build completed unsuccessfully in 0:21:20
[01:35:08] Build completed unsuccessfully in 0:21:20
[01:35:08] make: *** [check] Error 1
[01:35:08] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06e6be70
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Apr 26 16:01:12 UTC 2019
---
travis_time:end:2e219839:start=1556294474306746498,finish=1556294474311176498,duration=4430000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:03436480
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:14aa5288
travis_time:start:14aa5288
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:112a1cbb
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

dima74 · 2019-04-26T19:10:39Z

@GuillaumeGomez yes, added

rust-highfive · 2019-04-26T19:20:26Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0a096e33:start=1556305549262096979,finish=1556305550068333792,duration=806236813
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:03:34] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:35] tidy error: /checkout/src/librustdoc/html/render.rs:4142: line longer than 100 chars
[00:03:36] some tidy checks failed
[00:03:36] 
[00:03:36] 
[00:03:36] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:03:36] 
[00:03:36] 
[00:03:36] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:36] Build completed unsuccessfully in 0:00:48
[00:03:36] Build completed unsuccessfully in 0:00:48
[00:03:36] Makefile:67: recipe for target 'tidy' failed
[00:03:36] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1019e41a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Apr 26 19:09:37 UTC 2019
---
travis_time:end:0ad595b4:start=1556305778124779372,finish=1556305778130119261,duration=5339889
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1e3c8ac9
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:08980251
travis_time:start:08980251
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:09a39cb6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

…ific impls

GuillaumeGomez · 2019-04-27T11:25:30Z

Awesome! Thanks. :)

@bors: r+

bors · 2019-04-27T11:25:31Z

📌 Commit d2b4f4d has been approved by GuillaumeGomez

Make "Implementations on Foreign Types" items in sidebar link to specific impls This solves rust-lang#56018 for most cases (though not work for foreign impls with same names)

@ghost

Rollup of 5 pull requests Successful merges: - #60292 (Replace the `&'tcx List<Ty<'tcx>>` in `TyKind::Tuple` with `SubstsRef<'tcx>`) - #60307 (Make "Implementations on Foreign Types" items in sidebar link to specific impls) - #60309 (Add 1.34.1 release notes) - #60315 (bootstrap: use correct version numbers for llvm-tools and lldb) - #60316 (Use "capacity" as parameter name in with_capacity() methods) Failed merges: r? @ghost

rust-highfive assigned GuillaumeGomez Apr 26, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2019

Make "Implementations on Foreign Types" items in sidebar link to spec…

d2b4f4d

…ific impls

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2019

Centril mentioned this pull request Apr 27, 2019

Rollup of 6 pull requests #60328

Closed

Centril mentioned this pull request Apr 27, 2019

Rollup of 5 pull requests #60329

Merged

bors merged commit d2b4f4d into rust-lang:master Apr 27, 2019

dima74 deleted the fix/56018 branch April 27, 2019 22:30

workingjubilee mentioned this pull request Jun 19, 2025

rustdoc: "Implementations on Foreign Types" sidebar items should link to specific impls #56018

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make "Implementations on Foreign Types" items in sidebar link to specific impls#60307