Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1#60330
Merged
bors merged 9 commits intorust-lang:masterfrom May 1, 2019
Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
varkor
force-pushed
the
range-endpoint-overflow-lint
branch
from
ccdf86e to
5574826
Compare
Contributor
Author
|
r? @estebank |
varkor
commented
Apr 27, 2019
Centril
reviewed
Apr 27, 2019
estebank
approved these changes
Apr 30, 2019
Contributor
estebank
left a comment
estebank
left a comment
There was a problem hiding this comment.
looks good for the most part, with caveat of the style issues that centril pointed out
This comment has been minimized.
This comment has been minimized.
varkor
force-pushed
the
range-endpoint-overflow-lint
branch
from
5574826 to
80f90d8
Compare
Contributor
Author
|
I've done the suggested refactoring and pulled several functions out of |
estebank
approved these changes
Apr 30, 2019
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit b7711bf has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 1, 2019
…, r=estebank Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1 Fixes rust-lang#47213.
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 1, 2019
…, r=estebank Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1 Fixes rust-lang#47213.
bors
added a commit
that referenced
this pull request
May 1, 2019
Rollup of 7 pull requests Successful merges: - #60327 (Search for incompatible universes in borrow errors) - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1) - #60366 (build-gcc: Create missing cc symlink) - #60369 (Support ZSTs in DispatchFromDyn) - #60404 (Implement `BorrowMut<str>` for `String`) - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.) - #60432 (Update clippy) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 1, 2019
…, r=estebank Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1 Fixes rust-lang#47213.
bors
added a commit
that referenced
this pull request
May 1, 2019
Rollup of 7 pull requests Successful merges: - #60287 (Use references for variances_of) - #60327 (Search for incompatible universes in borrow errors) - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1) - #60366 (build-gcc: Create missing cc symlink) - #60369 (Support ZSTs in DispatchFromDyn) - #60404 (Implement `BorrowMut<str>` for `String`) - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47213.