Dont ICE on an attempt to use GAT without feature gate#61118
Merged
bors merged 3 commits intorust-lang:masterfrom May 25, 2019
Merged
Dont ICE on an attempt to use GAT without feature gate#61118bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit c235ba4 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 24, 2019
…t, r=varkor Dont ICE on an attempt to use GAT without feature gate Fix rust-lang#60654
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 24, 2019
…t, r=varkor Dont ICE on an attempt to use GAT without feature gate Fix rust-lang#60654
bors
added a commit
that referenced
this pull request
May 24, 2019
Rollup of 13 pull requests Successful merges: - #61077 (Don't arena-allocate static symbols.) - #61094 (Make find_local iterate instead of recurse) - #61095 (Update cargo) - #61096 (tidy: don't short-circuit on license error) - #61103 (Make find iterate instead of recurse) - #61104 (Make eval_place_to_op iterate instead of recurse) - #61107 (Fix a couple docs typos) - #61110 (Revert edition-guide toolstate override) - #61111 (Fixed type-alias-bounds lint doc) - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35) - #61116 (Remove the incorrect warning from README.md) - #61118 (Dont ICE on an attempt to use GAT without feature gate) - #61125 (Updated my mailmap entry) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 24, 2019
…t, r=varkor Dont ICE on an attempt to use GAT without feature gate Fix rust-lang#60654
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
…t, r=varkor Dont ICE on an attempt to use GAT without feature gate Fix rust-lang#60654
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Rollup of 13 pull requests Successful merges: - rust-lang#61026 (Tweak macro parse errors when reaching EOF during macro call parse) - rust-lang#61095 (Update cargo) - rust-lang#61096 (tidy: don't short-circuit on license error) - rust-lang#61107 (Fix a couple docs typos) - rust-lang#61110 (Revert edition-guide toolstate override) - rust-lang#61111 (Fixed type-alias-bounds lint doc) - rust-lang#61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35) - rust-lang#61116 (Remove the incorrect warning from README.md) - rust-lang#61118 (Dont ICE on an attempt to use GAT without feature gate) - rust-lang#61121 (improve debug-printing of scalars) - rust-lang#61125 (Updated my mailmap entry) - rust-lang#61134 (Annotate each `reverse_bits` with `#[must_use]`) - rust-lang#61138 (Move async/await tests to their own folder) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
May 25, 2019
Rollup of 13 pull requests Successful merges: - #61026 (Tweak macro parse errors when reaching EOF during macro call parse) - #61095 (Update cargo) - #61096 (tidy: don't short-circuit on license error) - #61107 (Fix a couple docs typos) - #61110 (Revert edition-guide toolstate override) - #61111 (Fixed type-alias-bounds lint doc) - #61113 (Deprecate `FnBox`. `Box<dyn FnOnce()>` can be called directly, since 1.35) - #61116 (Remove the incorrect warning from README.md) - #61118 (Dont ICE on an attempt to use GAT without feature gate) - #61121 (improve debug-printing of scalars) - #61125 (Updated my mailmap entry) - #61134 (Annotate each `reverse_bits` with `#[must_use]`) - #61138 (Move async/await tests to their own folder) Failed merges: r? @ghost
pnkfelix
added
beta-nominated
Contributor
Author
|
beta nominating based on observation that this sometimes resolves an ICE on code that does not use the feature gate mentioned here (I think); see #56445. |
Contributor
Author
|
discussed at T-compiler meeting. Accepting for beta-backport. |
pnkfelix
added
the
beta-accepted
emilyalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Jun 26, 2019
[beta] Rollup backports Rolled up: * [beta] Comment out dev key #61700 Cherry picked: * Dont ICE on an attempt to use GAT without feature gate #61118 * Fix cfg(test) build for x86_64-fortanix-unknown-sgx #61503 * Handle index out of bound errors during const eval without panic #61598 * Hygienize macros in the standard library #61629 * Fix ICE involving mut references #61947 * rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`. #61896 * Revert "Set test flag when rustdoc is running with --test option" #61199 * create a "provisional cache" to restore performance in the case of cycles #61754 r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #60654