Merged
Conversation
Based on the TODO, this case was added to short-circuit for ios builds, which is no longer necessary. The comment in this Makefile mentions rust-lang#29812 as a dependency, but that issue has been since closed, with a statement that the ICE of concern was resolved circa 1.12. Here we remove this case, and just run the same branch for all targets. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Since this case statement no longer has any branches, remove it. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
Didn't think it was this particular about things, but I also should have tested locally. It makes sense, though---`\` followed by LF would eat it, so we'd have `sysroot done` instead of `sysroot; done` as it is parsed. This should pass now. Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com> Tested-by: Kristofer Rye <kristofer.rye@gmail.com>
…r=wesleywiser Allow to specify profiling data output directory as -Zself-profile argument. The PR also makes `rustc` include the crate-name (if already available) in the output file name. r? @wesleywiser At some point we should add some basic tests for `-Zself-profile`.
split core::ptr module into multiple files Cc @Centril
rename Scalar::Bits to Scalar::Raw and bits field to data Also use this opportunity to seal some abstraction leaks (other modules constructing `Scalar::Bits` directly instead of using a constructor). r? @oli-obk
… r=alexcrichton Remove special case for *ios* builds in run-make-fulldeps/print-target-list Makefile Previous `TODO` comment in this file mentions [an issue that was closed](rust-lang#29812), and I was able to confirm locally that provided code in that issue no longer produces an ICE. Discussion on that issue seems to indicate this code was no longer needed as of 1.12.0. I removed the `*ios*` branch from this `case` statement as it may cause confusion, then removed the case statement entirely as it only had a wildcard branch.
Contributor
Author
|
@bors r+ p=4 rollup=never |
Collaborator
|
📌 Commit e06547f has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
May 28, 2019
Rollup of 4 pull requests Successful merges: - #61123 (Allow to specify profiling data output directory as -Zself-profile argument.) - #61159 (split core::ptr module into multiple files) - #61164 (rename Scalar::Bits to Scalar::Raw and bits field to data) - #61250 (Remove special case for *ios* builds in run-make-fulldeps/print-target-list Makefile) Failed merges: r? @ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
May 28, 2019
(which is included in rust-lang/rust#61274)
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
|
📣 Toolstate changed by #61274! Tested on commit 7212685. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 28, 2019
Tested on commit rust-lang/rust@7212685. Direct link to PR: <rust-lang/rust#61274> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
May 28, 2019
rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) changelog: none
This was referenced May 28, 2019
Closed
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
May 28, 2019
rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) changelog: none
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 30, 2019
Changes: ```` Rustup to rust-lang#61203 rustup rust-lang#60928 rustup rust-lang#61164 (which is included in rust-lang#61274) ````
bors
added a commit
that referenced
this pull request
May 31, 2019
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Changes: ```` Rustup to rust-lang/rust#61203 rustup rust-lang/rust#60928 rustup rust-lang/rust#61164 (which is included in rust-lang/rust#61274) ````
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost