Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
You may want to update libc only by |
|
☔ The latest upstream changes (presumably #57967) made this pull request unmergeable. Please resolve the merge conflicts. |
e62b4b3 to
f705c38
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☔ The latest upstream changes (presumably #61388) made this pull request unmergeable. Please resolve the merge conflicts. |
eadd725 to
7320770
Compare
|
☔ The latest upstream changes (presumably #61408) made this pull request unmergeable. Please resolve the merge conflicts. |
|
What is the status of this change? |
|
@gnzlbg this PR needs rebasing, do you have time to do it? |
|
I can rebase it, but I don't think doing that makes much sense until it's approved. The |
7c8879d to
e5fe002
Compare
|
@mati865 i've rebased it, but maybe somebody else wants to pick this PR up until it gets merged ? |
|
I would personally be fine landing this at any time so r=me, it's just likely going to be tricky navigating bugs in dependencies. |
|
Sorry, I wrongly thought it's reviewed and just waits for merging. I think you will have to add |
@mati865 what license should mach have ? |
|
EDIT: Actually on second thought it would fit better here: rust/src/tools/tidy/src/deps.rs Line 64 in 38cd948 I'm not the right person to ask.
rust/src/tools/tidy/src/deps.rs Line 30 in 38cd948 |
|
@mati865 would this be enough: fitzgen/mach#54 |
|
@gnzlbg I'm not a lawyer so I cannot tell if that relicensing would be OK (usually you need confirmation from all contributors). |
|
@bors: r+ |
|
📌 Commit 52caca0 has been approved by |
|
⌛ Testing commit 52caca0 with merge 86f7797cc4c0f575be1dfe0a80969808dd614cdd... |
|
💔 Test failed - checks-azure |
|
Let's retry this once: @bors: r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 52caca0 has been approved by |
|
☀️ Test successful - checks-azure |
Upgrade rand to 0.7 Also upgrades `getrandom` to avoid bug encountered by rust-lang#61393 which bumps libc to `0.2.62`. `wasi` crate was going to be added by rust-lang#63676 anyway.
Upgrade rand to 0.7 Also upgrades `getrandom` to avoid bug encountered by rust-lang#61393 which bumps libc to `0.2.62`.
No description provided.