Merged
Conversation
Seeing `StringError("something something")` in debug output can cause
someone to think there was an error dealing with `String`s, not that the
error type is just a string. So, remove that noise.
There is known issue where PowerShell is unreasonably slow downloading files due to an issue with rendering the progress bar, see: PowerShell/PowerShell#2138 That issue is fixed in PowerShell Core (available in Azure Pipelines as pwsh.exe) but it can also be worked around by setting: $ProgressPreference = 'SilentlyContinue'
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
error: remove StringError from Debug output
Seeing `StringError("something something")` in debug output can cause
someone to think there was an error dealing with `String`s, not that the
error type is just a string. So, remove that noise.
For example:
```
io error: Custom { kind: InvalidData, error: StringError("corrupt data") }
```
With this change:
```
io error: Custom { kind: InvalidData, error: "corrupt data" }
```
Speed up Azure CI installing Windows dependencies There is known issue where PowerShell is unreasonably slow downloading files due to an issue with rendering the progress bar, see this [issue](PowerShell/PowerShell#2138) That issue is fixed in PowerShell Core (available in Azure Pipelines as pwsh.exe) but it can also be worked around by setting: $ProgressPreference = 'SilentlyContinue' I measured downloading LLVM and it took about 220s before, 5s after, so the improvement is significant.
…amertj Swap order of `unsafe async fn` to `async unsafe fn` Change the order of `unsafe async fn` to `async unsafe fn`. I had intended to do this a while back but didn't get around to it... This should be done because: - It is the order used by `const unsafe fn` so therefore it is consistent. - This keeps all the "effect/restriction" modifiers to the left of `unsafe` (which according to some is not an effect) instead of mixing them such that we are more forward compatible with some sort of effect system. r? @cramertj
…e_patterns, r=Centril Set ellipsis_inclusive_range_patterns lint to warn Continuing rust-lang#54910, the `ellipsis_inclusive_range_patterns` lint is set to warn. r? @Centril
…Centril Add regression test for const generics ICE Closes rust-lang#60879.
… r=Manishearth Fix links in Deref documentation Fixes rust-lang#61358. In commonmark, the "link alias" has to be right after the link. Screenshot: <img width="970" alt="Screenshot 2019-05-30 at 19 01 58" src="https://user-images.githubusercontent.com/3050060/58650155-3b594e00-830e-11e9-956c-4dadefa40ff0.png"> r? @Manishearth
…entril Stabilize iter_nth_back feature FCP done in rust-lang#56995 (comment) Closes rust-lang#56995 r? @Centril
Fixed lifetime misspelling
…omez Migrate some books to mdbook version 0.2 There are 3 books still using old version but they need more effort so I hope to do them in subsequent PR if I find the time.
Explicitly suggest 'type_ascription' feature Closes: rust-lang#61325 r? @estebank
Fixed a typo in core::convert::AsMut Just missing a space, and added a comma to make more idiomatic.
Member
Author
|
@bors r+ p=11 |
Collaborator
|
📌 Commit e32386d has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit e32386d with merge 73199135003cbff9edb5a0872180897e1f8074d2... |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
Contributor
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit e32386d with merge 2a6b281039d680c7eb53374902f21564180cd535... |
Collaborator
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
@bors retry Looks spurious to me.. |
bors
added
S-waiting-on-bors
Member
Collaborator
bors
added a commit
that referenced
this pull request
Jun 1, 2019
Rollup of 11 pull requests Successful merges: - #60897 (error: remove StringError from Debug output) - #61304 (Speed up Azure CI installing Windows dependencies) - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`) - #61342 (Set ellipsis_inclusive_range_patterns lint to warn) - #61344 (Add regression test for const generics ICE) - #61359 (Fix links in Deref documentation) - #61363 (Stabilize iter_nth_back feature) - #61369 (Fixed lifetime misspelling) - #61372 (Migrate some books to mdbook version 0.2) - #61374 (Explicitly suggest 'type_ascription' feature) - #61382 (Fixed a typo in core::convert::AsMut) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
|
📣 Toolstate changed by #61394! Tested on commit 84f729d. 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 1, 2019
Tested on commit rust-lang/rust@84f729d. Direct link to PR: <rust-lang/rust#61394> 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
This was referenced Jun 1, 2019
Member
|
Looks like that's a spurious toolstate breakage? I can't really tell with the new Azure stuff. |
Member
|
It's not spurious, see https://api.travis-ci.com/v3/job/204667069/log.txt and search |
Member
|
Ah, its an issue that was already fixed on clippy master. I see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
unsafe async fntoasync unsafe fn#61319 (Swap order ofunsafe async fntoasync unsafe fn)Failed merges:
r? @ghost