Merged
Conversation
…l ones by black_box (with a comment)
Unlike other built-in attributes, this attribute accepts any input
Remove useless allocations in macro_rules follow logic. Closes rust-lang#61543
remove useless ident() functions in const tests and replace the useful ones by black_box (with a comment) r? @oli-obk
Minimize use of `#![feature(custom_attribute)]` Some preparations before resurrecting rust-lang#57921.
Add test for trait ICE Closes rust-lang#55266
syntax: Remove `Deref` impl from `Token` Follow up to rust-lang#61541 r? @oli-obk
Update RLS This bumps the version to 1.37 and also doesn't build clippy by default (should reduce toolstate breakages, see rust-lang#59761 (comment) for more details) r? @oli-obk
Contributor
Author
|
@bors r+ p=6 rollup=never |
Collaborator
|
📌 Commit e0c825c has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Jun 8, 2019
Rollup of 6 pull requests Successful merges: - #61646 (Remove useless allocations in macro_rules follow logic.) - #61658 (remove useless ident() functions in const tests) - #61660 (Minimize use of `#![feature(custom_attribute)]`) - #61666 (Add test for trait ICE) - #61669 ( syntax: Remove `Deref` impl from `Token`) - #61670 (Update RLS) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
|
📣 Toolstate changed by #61672! Tested on commit 053666f. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 9, 2019
Tested on commit rust-lang/rust@053666f. Direct link to PR: <rust-lang/rust#61672> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
Member
|
Toolstate is probably #61669 |
This was referenced Jun 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
#![feature(custom_attribute)]#61660 (Minimize use of#![feature(custom_attribute)])Derefimpl fromToken#61669 ( syntax: RemoveDerefimpl fromToken)Failed merges:
r? @ghost