Remove mentions of removed offset_to method from align_offset docs#61965
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 30, 2019
Merged
Remove mentions of removed offset_to method from align_offset docs#61965bors merged 2 commits intorust-lang:masterfrom
offset_to method from align_offset docs#61965bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
scottmcm
reviewed
Jul 6, 2019
The `align_offset` method returns an `usize`, so using `add` makes more sense than using `offset`, which takes an `isize`.
Member
|
Ping from triage: waiting on your review @joshtriplett |
Member
Collaborator
|
📌 Commit c9c73f5 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 29, 2019
Remove mentions of removed `offset_to` method from `align_offset` docs The `offset_to` method was deleted in rust-lang#52814. The replacement for the removed method is `wrapping_offset_from`. However, neither method takes an `usize` as argument, so I don't think that it makes sense to mention them.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 29, 2019
Remove mentions of removed `offset_to` method from `align_offset` docs The `offset_to` method was deleted in rust-lang#52814. The replacement for the removed method is `wrapping_offset_from`. However, neither method takes an `usize` as argument, so I don't think that it makes sense to mention them.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 30, 2019
Remove mentions of removed `offset_to` method from `align_offset` docs The `offset_to` method was deleted in rust-lang#52814. The replacement for the removed method is `wrapping_offset_from`. However, neither method takes an `usize` as argument, so I don't think that it makes sense to mention them.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 30, 2019
Remove mentions of removed `offset_to` method from `align_offset` docs The `offset_to` method was deleted in rust-lang#52814. The replacement for the removed method is `wrapping_offset_from`. However, neither method takes an `usize` as argument, so I don't think that it makes sense to mention them.
bors
added a commit
that referenced
this pull request
Jul 30, 2019
Rollup of 12 pull requests Successful merges: - #61965 (Remove mentions of removed `offset_to` method from `align_offset` docs) - #62928 (Syntax: Recover on `for ( $pat in $expr ) $block`) - #63000 (Impl Debug for Chars) - #63083 (Make generic parameters always use modern hygiene) - #63087 (Add very simple edition check to tidy.) - #63093 (Properly check the defining scope of existential types) - #63096 (Add tests for some `existential_type` ICEs) - #63099 (vxworks: Remove Linux-specific comments.) - #63106 (ci: Skip installing SWIG/xz on OSX ) - #63108 (Add links to None in Option doc) - #63109 (std: Fix a failing `fs` test on Windows) - #63111 (Add syntactic and semantic tests for rest patterns, i.e. `..`) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
offset_tomethod was deleted in #52814.The replacement for the removed method is
wrapping_offset_from. However, neither method takes anusizeas argument, so I don't think that it makes sense to mention them.