Merged
Conversation
Contributor
Not the worst problem to have =P @bors delegate+ |
Collaborator
|
✌️ @ljedrz can now approve this pull request |
Contributor
Author
|
@bors r=Zoxc |
Collaborator
|
📌 Commit 87438a1 has been approved by |
Collaborator
|
⌛ Testing commit 87438a1 with merge dbfeb9da46149eb475c6e5bc0c27b12d3a1b661a... |
Collaborator
|
💔 Test failed - checks-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
@bors retry |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 25, 2019
… r=Zoxc
HirIdification: almost there
I'm beginning to run out of stuff to HirIdify 😉.
This time I targeted mainly `hir::map::{find, get_parent_node}`, but a few other bits got changed too.
r? @Zoxc
bors
added a commit
that referenced
this pull request
Jun 25, 2019
Rollup of 7 pull requests Successful merges: - #61814 (Fix an ICE with uninhabited consts) - #61987 (rustc: produce AST instead of HIR from `hir::lowering::Resolver` methods.) - #62055 (Fix error counting) - #62078 (Remove built-in derive macros `Send` and `Sync`) - #62085 (Add test for issue-38591) - #62091 (HirIdification: almost there) - #62096 (Implement From<Local> for Place and PlaceBase) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm beginning to run out of stuff to HirIdify 😉.
This time I targeted mainly
hir::map::{find, get_parent_node}, but a few other bits got changed too.r? @Zoxc