Use sharded maps for queries#62108

Zoxc · 2019-06-25T02:34:56Z

Based on #61779.

Gankra · 2019-06-25T02:40:26Z

I continue to be fine with the sharding implementation, but am not a rust-lang reviewer, and also don't know about the actual rustc code (seems largely mechanical?)

Zoxc · 2019-06-25T02:44:05Z

r? @oli-obk

src/librustc_data_structures/sharded.rs

bors · 2019-06-30T15:44:49Z

☔ The latest upstream changes (presumably #59722) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2019-07-01T10:33:05Z

@bors try

bors · 2019-07-01T10:33:22Z

⌛ Trying commit 190afcf33d817f6733761ec0ca3d31830674a9f6 with merge 6396e7058917ab50a5a63b857866aef9499d7f4f...

bors · 2019-07-01T14:33:23Z

💥 Test timed out

Zoxc · 2019-07-01T14:57:00Z

@rust-timer build 6396e7058917ab50a5a63b857866aef9499d7f4f

rust-timer · 2019-07-01T14:57:02Z

Success: Queued 6396e7058917ab50a5a63b857866aef9499d7f4f with parent 765eebf, comparison URL.

rust-timer · 2019-07-01T18:08:53Z

Finished benchmarking try commit 6396e7058917ab50a5a63b857866aef9499d7f4f, comparison URL.

bors · 2019-07-04T22:18:20Z

☔ The latest upstream changes (presumably #61392) made this pull request unmergeable. Please resolve the merge conflicts.

edmilsonefs · 2019-07-22T19:31:11Z

Hey! This is a ping from triage, we would like to know if you @oli-obk or @Zoxc could give us a few more minutes to update here so we can move forward .

Thanks.

oli-obk · 2019-07-23T06:23:45Z

It's waiting for #61779 to get merged first

bors · 2019-07-23T13:42:58Z

☔ The latest upstream changes (presumably #61779) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2019-07-24T02:46:11Z

Rebased out #61779.

bors · 2019-07-26T02:25:51Z

☔ The latest upstream changes (presumably #62990) made this pull request unmergeable. Please resolve the merge conflicts.

wirelessringo · 2019-08-02T20:08:20Z

Ping from triage. @oli-obk any updates on this? Thank you.

JohnTitor · 2019-08-11T13:38:07Z

Ping from triage: @oli-obk do you have time to review this?

oli-obk · 2019-08-11T15:04:09Z

@bors r+

bors · 2019-08-11T15:04:10Z

📌 Commit f84967f has been approved by oli-obk

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

@ghost

Rollup of 8 pull requests Successful merges: - #61969 (Add #[repr(transparent)] for several types) - #62108 (Use sharded maps for queries) - #63149 (resolve: Populate external modules in more automatic and lazy way) - #63346 (Lint on some incorrect uses of mem::zeroed / mem::uninitialized) - #63433 (Miri shouldn't look at types) - #63440 (rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE) - #63442 (Add an example to show how to insert item to a sorted vec) - #63459 (syntax: account for CVarArgs being in the argument list.) Failed merges: r? @ghost

bors · 2019-08-12T06:18:57Z

⌛ Testing commit f84967f with merge 89fdc8d69e670a619552e804b1d8fa939e67497a...

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

Centril · 2019-08-12T06:57:44Z

@bors retry rolled up.

@ghost

Rollup of 10 pull requests Successful merges: - #62108 (Use sharded maps for queries) - #63297 (Improve pointer offset method docs) - #63306 (Adapt AddRetag for shallow retagging) - #63406 (Suggest using a qualified path in patterns with inconsistent bindings) - #63431 (Revert "Simplify MIR generation for logical ops") - #63449 (resolve: Remove remaining special cases from built-in macros) - #63461 (docs: add stdlib env::var(_os) panic) - #63473 (Regression test for #56870) - #63474 (Add tests for issue #53598 and #57700) - #63480 (Fixes #63477) Failed merges: r? @ghost

bors · 2019-08-12T08:39:26Z

⌛ Testing commit f84967f with merge 57aa2117c37824d1af595c36f7d178e65cb81219...

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

Centril · 2019-08-12T08:58:43Z

@bors retry rolled up.

@ghost

Rollup of 9 pull requests Successful merges: - #62108 (Use sharded maps for queries) - #63297 (Improve pointer offset method docs) - #63406 (Suggest using a qualified path in patterns with inconsistent bindings) - #63431 (Revert "Simplify MIR generation for logical ops") - #63449 (resolve: Remove remaining special cases from built-in macros) - #63461 (docs: add stdlib env::var(_os) panic) - #63473 (Regression test for #56870) - #63474 (Add tests for issue #53598 and #57700) - #63480 (Fixes #63477) Failed merges: r? @ghost

rust-highfive assigned Gankra Jun 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 25, 2019

Zoxc mentioned this pull request Jun 25, 2019

Use sharded maps for interning #61779

Merged

rust-highfive assigned oli-obk and unassigned Gankra Jun 25, 2019

oli-obk requested changes Jun 26, 2019

View reviewed changes

Zoxc force-pushed the sharded-queries branch from c557857 to 190afcf Compare July 1, 2019 10:20

Zoxc changed the title ~~[WIP] Use sharded maps for queries~~ Use sharded maps for queries Jul 5, 2019

Zoxc force-pushed the sharded-queries branch from 190afcf to 1f58a1b Compare July 5, 2019 10:21

Zoxc force-pushed the sharded-queries branch from 1f58a1b to 00dcd33 Compare July 24, 2019 02:42

Use sharded maps for queries

f84967f

Zoxc force-pushed the sharded-queries branch from 00dcd33 to f84967f Compare July 26, 2019 03:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2019

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 11, 2019

Rollup merge of rust-lang#62108 - Zoxc:sharded-queries, r=oli-obk

6381937

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

Mark-Simulacrum mentioned this pull request Aug 11, 2019

Rollup of 8 pull requests #63465

Closed

Centril added a commit to Centril/rust that referenced this pull request Aug 12, 2019

Rollup merge of rust-lang#62108 - Zoxc:sharded-queries, r=oli-obk

4f1cc83

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

Centril mentioned this pull request Aug 12, 2019

Rollup of 10 pull requests #63482

Closed

Centril added a commit to Centril/rust that referenced this pull request Aug 12, 2019

Rollup merge of rust-lang#62108 - Zoxc:sharded-queries, r=oli-obk

0b4823d

Use sharded maps for queries Based on rust-lang#61779. r? @gankro

Centril mentioned this pull request Aug 12, 2019

Rollup of 9 pull requests #63489

Merged

bors merged commit f84967f into rust-lang:master Aug 12, 2019

Zoxc deleted the sharded-queries branch August 20, 2019 18:11

Uh oh!

Conversation

Zoxc commented Jun 25, 2019

Uh oh!

Gankra commented Jun 25, 2019

Uh oh!

Zoxc commented Jun 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Jun 30, 2019

Uh oh!

Zoxc commented Jul 1, 2019

Uh oh!

bors commented Jul 1, 2019

Uh oh!

bors commented Jul 1, 2019

Uh oh!

Zoxc commented Jul 1, 2019

Uh oh!

rust-timer commented Jul 1, 2019

Uh oh!

rust-timer commented Jul 1, 2019

Uh oh!

bors commented Jul 4, 2019

Uh oh!

edmilsonefs commented Jul 22, 2019

Uh oh!

oli-obk commented Jul 23, 2019

Uh oh!

bors commented Jul 23, 2019

Uh oh!

Zoxc commented Jul 24, 2019

Uh oh!

bors commented Jul 26, 2019

Uh oh!

wirelessringo commented Aug 2, 2019

Uh oh!

JohnTitor commented Aug 11, 2019

Uh oh!

oli-obk commented Aug 11, 2019

Uh oh!

bors commented Aug 11, 2019

Uh oh!

bors commented Aug 12, 2019

Uh oh!

Centril commented Aug 12, 2019

Uh oh!

bors commented Aug 12, 2019

Uh oh!

Centril commented Aug 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants