Replace unsafe_destructor_blind_to_params with may_dangle#62568
Merged
bors merged 2 commits intorust-lang:masterfrom Jul 13, 2019
Merged
Replace unsafe_destructor_blind_to_params with may_dangle#62568bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
Or should I remove support for |
Contributor
Contributor
matthewjasper
left a comment
matthewjasper
left a comment
There was a problem hiding this comment.
Or should I remove support for
#[unsafe_destructor_blind_to_params]attribute completely?
Yes
#[may_dangle] is unsafe, so all of the implementations using it need to be unsafe impls.
7 tasks
Contributor
Author
Yup! I completely forgot about that. |
tesuji
force-pushed
the
replace_may_dangle
branch
2 times, most recently
from
5afcf80 to
c2d96da
Compare
Contributor
Author
|
The build is passed. |
Contributor
matthewjasper
left a comment
matthewjasper
left a comment
There was a problem hiding this comment.
Could you re-wrap the text in comments that now have a short line?
Therefore we also remove `#[unsafe_destructor_blind_to_params]` attribute completly.
tesuji
force-pushed
the
replace_may_dangle
branch
from
c2d96da to
6d66fe2
Compare
tesuji
commented
Jul 11, 2019
src/libsyntax/feature_gate.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
Is this correct? This features is unstable since 1.3.0.
Member
There was a problem hiding this comment.
AFAIK unstable features just disappear entirely, no need to keep any trace of them around.
tesuji
force-pushed
the
replace_may_dangle
branch
from
6d66fe2 to
8347917
Compare
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 8347917 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 12, 2019
…wjasper Replace unsafe_destructor_blind_to_params with may_dangle This PR will completely remove support for `#[unsafe_destructor_blind_to_params]` attribute, which is deprecated in rust-lang#38970 by `[may_dangle]` unsafe attribute. Closes rust-lang#34761
bors
added a commit
that referenced
this pull request
Jul 12, 2019
Rollup of 12 pull requests Successful merges: - #61535 (Coherence test when a generic type param has a default value from an associated type) - #62274 (rustc_mir: follow FalseUnwind's real_target edge in qualify_consts.) - #62431 (Add messages to `Option`'s and `Result`'s `must_use` annotation for `is_*`) - #62453 (in which we suggest anonymizing single-use lifetimes in paths ) - #62568 (Replace unsafe_destructor_blind_to_params with may_dangle) - #62578 (Add test for #49919) - #62595 (Document that the crate keyword refers to the project root) - #62599 (move mem::uninitialized deprecation back by 1 release, to 1.39) - #62605 (Emit dropped unemitted errors to aid in ICE debugging) - #62607 (Correctly break out of recovery loop) - #62608 (`async unsafe fn` tests) - #62623 (downgrade indirect_structural_match lint to allow) Failed merges: r? @ghost
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will completely remove support for
#[unsafe_destructor_blind_to_params]attribute,which is deprecated in #38970 by
[may_dangle]unsafe attribute.Closes #34761