Conversation
It is produced during `./x.py test`
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
@bors rollup |
RalfJung
reviewed
Aug 10, 2019
Member
|
Would be great if you could also add a comment for |
Contributor
Author
|
@RalfJung Done :) |
RalfJung
approved these changes
Aug 10, 2019
Member
RalfJung
left a comment
RalfJung
left a comment
There was a problem hiding this comment.
LGTM. I'd say r=me but I feel this is outside my jurisdiction.^^
Member
|
@bors r+ I think .gitignore is both outside and inside everyone's jurisdiction.. tragedy of the commons and all. |
Collaborator
|
📌 Commit 83b837a has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
FYI, there's an issue about removing this |
Contributor
Author
|
@petrochenkov Thanks for the cc; Let's remove it again when it isn't produced anymore :) |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 10, 2019
…rk-Simulacrum .gitignore: Readd `/tmp/` Specifically, `/tmp/partitioning-tests/` it is generated by the incremental tests, https://github.com/rust-lang/rust/search?p=2&q=partitioning-tests&unscoped_q=partitioning-tests. These are cleaned up by compiletest but not if you kill testing prematurely (which I just did to test out a rollup, and it is annoying to `rm -rf tmp/`). r? @Mark-Simulacrum cc @RalfJung
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically,
/tmp/partitioning-tests/it is generated by the incremental tests, https://github.com/rust-lang/rust/search?p=2&q=partitioning-tests&unscoped_q=partitioning-tests. These are cleaned up by compiletest but not if you kill testing prematurely (which I just did to test out a rollup, and it is annoying torm -rf tmp/).r? @Mark-Simulacrum
cc @RalfJung