Don't special case the Self parameter by name#63463
Merged
bors merged 4 commits intorust-lang:masterfrom Aug 19, 2019
Merged
Conversation
petrochenkov
added
the
S-waiting-on-author
Contributor
Author
|
@bors try |
Collaborator
Collaborator
|
☀️ Try build successful - checks-azure |
Contributor
Author
|
@rust-timer build |
Contributor
|
@rust-timer build bbd6744 AFAIK, rust-timer cannot detect the commit automatically. |
Collaborator
|
Success: Queued bbd6744 with parent 60960a2, comparison URL. |
src/librustc/ty/context.rs
Outdated
| #[inline] | ||
| pub fn mk_self_type(self) -> Ty<'tcx> { | ||
| self.mk_ty_param(0, kw::SelfUpper.as_interned_str()) | ||
| self.types.self_param |
Contributor
There was a problem hiding this comment.
Looks like mk_self_type isn't commonly used, perhaps it can be removed in favor of using self.types.self_param directly?
petrochenkov
added
S-waiting-on-perf
Collaborator
|
Finished benchmarking try commit bbd6744, comparison URL. |
matthewjasper
added
S-waiting-on-author
Use this to simplify the object safety code a bit.
matthewjasper
force-pushed
the
ty_param_cleanup
branch
from
4657ad1 to
24587d2
Compare
matthewjasper
added
S-waiting-on-review
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 24587d2 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in a couple of small diagnostic regressions. They could be avoided by keeping the special case just for diagnostics, but that seems worse.
closes #50125
cc #60869