Merged
Conversation
This update includes the ability to warn on deprecated config keys. It's important to be able to warn the user whenever they're using an old configuration rather than giving them a cryptic "unknown configuration error" cc rust-lang/vscode-rust#639 Since we removed a config value in the current nightly, it'd be very good if this change can make also make it before cutting the next release.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ p=1 |
Collaborator
|
📌 Commit c8a2855 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Aug 11, 2019
Update RLS This update includes the ability to warn on deprecated config keys. It's important to be able to warn the user whenever they're using an old configuration rather than giving them a cryptic "unknown configuration error" cc rust-lang/vscode-rust#639 Since we removed a config value in the current nightly, it'd be very good if this change can make also make it before cutting the next release.
Collaborator
|
☀️ Test successful - checks-azure |
Xanewok
added a commit
to Xanewok/rust
that referenced
this pull request
Aug 12, 2019
This fixes handling default configuration for the `crate_blacklist` RLS configuration. Technically this isn't needed, as the VS Code extension can be configured to accept a predefined blacklist that's equal to the default one but it's best that it also lands so that we don't need to work around that. cc rust-lang#63472
Merged
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 14, 2019
Update RLS This fixes handling default configuration for the `crate_blacklist` RLS configuration. Technically this isn't needed, as the VS Code extension can be configured to accept a predefined blacklist that's equal to the default one but it's best that it also lands so that we don't need to work around that. Without this, manually passing a `null` value as the configuration unfortunately crashes the RLS. This is the last fix related to configuration. cc rust-lang#63472 r? @Mark-Simulacrum
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
Update RLS This fixes handling default configuration for the `crate_blacklist` RLS configuration. Technically this isn't needed, as the VS Code extension can be configured to accept a predefined blacklist that's equal to the default one but it's best that it also lands so that we don't need to work around that. Without this, manually passing a `null` value as the configuration unfortunately crashes the RLS. This is the last fix related to configuration. cc rust-lang#63472 r? @Mark-Simulacrum
bors
added a commit
that referenced
this pull request
Aug 17, 2019
Update RLS This fixes handling default configuration for the `crate_blacklist` RLS configuration. Technically this isn't needed, as the VS Code extension can be configured to accept a predefined blacklist that's equal to the default one but it's best that it also lands so that we don't need to work around that. Without this, manually passing a `null` value as the configuration unfortunately crashes the RLS. This is the last fix related to configuration. cc #63472 r? @Mark-Simulacrum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update includes the ability to warn on deprecated config keys.
It's important to be able to warn the user whenever they're using
an old configuration rather than giving them a cryptic "unknown
configuration error"
cc rust-lang/vscode-rust#639
Since we removed a config value in the current nightly, it'd be
very good if this change can make also make it before cutting the
next release.