Conversation
rust-highfive
added
the
S-waiting-on-review
src/bootstrap/bin/rustc.rs
Outdated
Contributor
There was a problem hiding this comment.
The "rustc_version" part was also supposed to be removed during the bump.
("Mis-reports the stage" means reporting "not bootstrap" while it was actually "bootstrap".)
Centril
approved these changes
Aug 13, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
cfg(bootstrap) related changes look good aside from @petrochenkov's note.
r=me when-green with that fixed
Mark-Simulacrum
force-pushed
the
stage0-bump
branch
from
c41e394 to
28d2279
Compare
Member
Author
|
@bors r=Centril p=10 |
Collaborator
|
📌 Commit 28d2279 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Aug 14, 2019
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Contributor
|
Seems like hashbrown is using cc @Amanieu |
bors
added
S-waiting-on-author
Member
|
@Centril The errors in the log don't seem to have anything to do with hashbrown? |
This is needed to permit us building core_arch which is a submodule dep (so we can't snap it to the new beta compiler).
Mark-Simulacrum
force-pushed
the
stage0-bump
branch
from
28d2279 to
f7ff36d
Compare
Member
Author
|
Yeah, I think that's just cloudabi. Fixed (I think). @bors r=Centril |
Collaborator
|
📌 Commit f7ff36d has been approved by |
bors
added
S-waiting-on-bors
Member
Author
|
@bors p=50 |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Contributor
|
@bors retry rolled up |
bors
added a commit
that referenced
this pull request
Aug 14, 2019
Rollup of 10 pull requests Successful merges: - #62984 (Add lint for excess trailing semicolons) - #63075 (Miri: Check that a ptr is aligned and inbounds already when evaluating `*`) - #63490 (libsyntax: cleanup and refactor `pat.rs`) - #63495 ( Remove redundant `ty` fields from `mir::Constant` and `hair::pattern::PatternRange`.) - #63509 (Point at the right enclosing scope when using `await` in non-async fn) - #63528 (syntax: Remove `DummyResult::expr_only`) - #63534 (Bump to 1.39) - #63537 (expand: Unimplement `MutVisitor` on `MacroExpander`) - #63542 (Add NodeId for Arm, Field and FieldPat) - #63560 (move test that shouldn't be in test/run-pass/) Failed merges: r? @ghost
Collaborator
|
⌛ Testing commit f7ff36d with merge 260c22c85d162bdc9cf938d0da7dbb77c823a7e3... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 14, 2019
Contributor
|
@bors retry rolled up |
Collaborator
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
|
📣 Toolstate changed by #63534! Tested on commit 082cf2f. 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Aug 15, 2019
Tested on commit rust-lang/rust@082cf2f. Direct link to PR: <rust-lang/rust#63534> 💔 clippy-driver on windows: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → test-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 16, 2019
… r=alexreg libcore: more cleanups using `#![feature(associated_type_bounds)]` Turns out this was indeed a bootstrapping issue from a test with `./x.py check` locally after rust-lang#63534 merged. Closes rust-lang#63393 r? @alexreg cc @iluuu1994 cc rust-lang#52662
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Centril