Skip to content

Update miri submodule#64308

Merged
bors merged 1 commit intorust-lang:masterfrom
oli-obk:miri
Sep 10, 2019
Merged

Update miri submodule#64308
bors merged 1 commit intorust-lang:masterfrom
oli-obk:miri

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 9, 2019

fixes #64244

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 9, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 9, 2019

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2019
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 9, 2019

@bors r+ p=1 (self r+ing due to no in-repo changes)

@bors
Copy link
Collaborator

bors commented Sep 9, 2019

📌 Commit 3d7040b has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2019
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 9, 2019

r? @ghost

@tmandry tmandry mentioned this pull request Sep 9, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Sep 10, 2019
@Centril
Rollup merge of rust-lang#64308 - oli-obk:miri, r=oli-obk
c5a2e14 
Update miri submodule

fixes rust-lang#64244
@Centril Centril mentioned this pull request Sep 10, 2019
Merged
bors added a commit that referenced this pull request Sep 10, 2019
@bors
Auto merge of #64333 - Centril:rollup-llhhr82, r=Centril
61dced1 
Rollup of 4 pull requests

Successful merges:

 - #64307 (Update clippy)
 - #64308 (Update miri submodule)
 - #64318 (update reference)
 - #64323 (Always show backtrace on Fuchsia)

Failed merges:

r? @ghost
@bors bors merged commit 3d7040b into rust-lang:master Sep 10, 2019
@bors
Copy link
Collaborator

bors commented Sep 10, 2019

⌛ Testing commit 3d7040b with merge 61dced1...

@emilyalbini
Copy link
Member

emilyalbini commented Sep 23, 2019

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 23, 2019
@tmandry
Copy link
Member

tmandry commented Sep 27, 2019

why was this r-?

@eddyb
Copy link
Member

eddyb commented Sep 27, 2019

@tmandry IIUC, there's a bors bug where sometimes it starts a build just after the PR has been merged as part of a rollup.
That build gets cancelled or something but the PR stays in a weird state until someone does what @pietroalbini did, is my guess.

@emilyalbini
Copy link
Member

emilyalbini commented Sep 27, 2019

Yep, basically what @eddyb said. The bug shows up usually after we restart bors.

@tmandry
Copy link
Member

tmandry commented Sep 27, 2019

oh, I see, thanks. I somehow didn't see that this was merged =)

@oli-obk oli-obk deleted the miri branch March 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#64230

7 participants

@oli-obk @rust-highfive @bors @emilyalbini @tmandry @eddyb @alexcrichton