libcore: Move position and rposition methods to ImmutableVector trait#6468
Closed
gifnksm wants to merge 1 commit intorust-lang:incomingfrom
gifnksm:rposition-immutable
Closed
libcore: Move position and rposition methods to ImmutableVector trait#6468gifnksm wants to merge 1 commit intorust-lang:incomingfrom gifnksm:rposition-immutable
position and rposition methods to ImmutableVector trait#6468gifnksm wants to merge 1 commit intorust-lang:incomingfrom
gifnksm:rposition-immutable
Conversation
bors
added a commit
that referenced
this pull request
May 14, 2013
`position` and `rposition` belonged to `ImmutableCopyableVector`, but they don't need the value is copyable.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
…for-rustbot, r=flip1995 Renamed the good first issue label for rustbot The `good first issue` label got renamed to `good-first-issue`. See [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Rename.20the.20.22good.20first.20issue.22.20label.20for.20bot.20usage/near/220428379) to enable the assignment with rustbot. changelog: None r? `@flip1995`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 20, 2020
…in-docs, r=flip1995 Renamed the good first issue label in CONTRIBUTING.md Follow up from rust-lang#6468 Grep found some more references to the old `good first issue`. [CONTRIBUTING.md rendered](https://github.com/xFrednet/rust-clippy/blob/0000-rename-good-first-issue-in-docs/CONTRIBUTING.md) <details> <summary>grep output</summary> ``` $ grep -Ri "good first issue" rust-clippy/ rust-clippy/.git/COMMIT_EDITMSG:Renamed the good first issue label in CONTRIBUTING.md rust-clippy/.git/logs/HEAD:896d82f7ff64644656bda7a4ed8bbd55ca3b7619 1f58c2b xFrednet <xFrednet@gmail.com> 1608326295 +0000 commit: Renamed the good first issue label for rustbot rust-clippy/.git/logs/HEAD:9be704584f05e5a6c3ba2708590f98c1f261d19a ced54f2 xFrednet <xFrednet@gmail.com> 1608329602 +0000 commit: Renamed the good first issue label in CONTRIBUTING.md rust-clippy/.git/logs/refs/heads/0000-rename-good-first-issue-in-docs:896d82f7ff64644656bda7a4ed8bbd55ca3b7619 1f58c2b xFrednet <xFrednet@gmail.com> 1608326295 +0000 commit: Renamed the good first issue label for rustbot rust-clippy/.git/logs/refs/heads/0000-rename-good-first-issue-in-docs:9be704584f05e5a6c3ba2708590f98c1f261d19a ced54f2 xFrednet <xFrednet@gmail.com> 1608329602 +0000 commit: Renamed the good first issue label in CONTRIBUTING.md rust-clippy/CONTRIBUTING.md:Some issues are easier than others. The [`good first issue`] label can be used to find the easy issues. rust-clippy/CONTRIBUTING.md:[`E-medium`] issues are generally pretty easy too, though it's recommended you work on an [`good first issue`] rust-clippy/CONTRIBUTING.md:[`good first issue`]: https://github.com/rust-lang/rust-clippy/labels/good%20first%20issue ``` </details> --- changelog: None r? `@flip1995`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
positionandrpositionbelonged toImmutableCopyableVector, but they don't need the value is copyable.