update mem::discriminant test to use assert_eq and assert_ne over comparison operators#64717
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 25, 2019
andrewbanchich:master
Merged
update mem::discriminant test to use assert_eq and assert_ne over comparison operators#64717bors merged 1 commit intorust-lang:masterfrom andrewbanchich:master
bors merged 1 commit intorust-lang:masterfrom
andrewbanchich:master
Conversation
Use assert_eq and assert_ne over comparison operators.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
The change looks reasonable. However, could you please use a more descriptive subject than "update test"? Don't leave all the details to the body of the commit message. r=me (and bors rollup) with that fixed. |
andrewbanchich
changed the title
Contributor
Author
|
@joshtriplett Sure, all set! Let me know if you need anything else. r? @joshtriplett |
Collaborator
|
@andrewbanchich: 🔑 Insufficient privileges: Not in reviewers |
Collaborator
|
@andrewbanchich: 🔑 Insufficient privileges: not in try users |
Contributor
Author
|
Whoops, so you meant I should add |
Collaborator
|
@andrewbanchich: 🔑 Insufficient privileges: Not in reviewers |
Contributor
|
@bors r=joshtriplett rollup |
Collaborator
|
📌 Commit 8acf958 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@andrewbanchich r=me generally means that someone with approval rights can do r=reviewer but if you don't have approval rights then you'll have to wait. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 24, 2019
update mem::discriminant test to use assert_eq and assert_ne over comparison operators Use assert_eq and assert_ne over comparison operators.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 24, 2019
update mem::discriminant test to use assert_eq and assert_ne over comparison operators Use assert_eq and assert_ne over comparison operators.
bors
added a commit
that referenced
this pull request
Sep 24, 2019
Rollup of 16 pull requests Successful merges: - #63356 (Issue#63183: Add fs::read_dir() and ReadDir warning about iterator order + example) - #63934 (Fix coherence checking for impl trait in type aliases) - #64016 (Streamline `Compiler`) - #64296 (Document the unstable iter_order_by library feature) - #64443 (rustdoc: general cleanup) - #64622 (Add a cycle detector for generic `Graph`s and `mir::Body`s) - #64689 (Refactor macro by example) - #64698 (Recover on `const X = 42;` and infer type + Error Stash API) - #64702 (Remove unused dependencies) - #64717 (update mem::discriminant test to use assert_eq and assert_ne over comparison operators) - #64720 ( remove rtp.rs, and move rtpSpawn and RTP_ID_ERROR to libc) - #64721 (Fixed issue from #64447) - #64725 (fix one typo) - #64737 (fix several issues in String docs) - #64742 (relnotes: make compatibility section more sterile and fix rustc version) - #64748 (Fix #64744. Account for the Zero sub-pattern case.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use assert_eq and assert_ne over comparison operators.