Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ehuss
force-pushed
the
document-json
branch
from
5ce8108 to
f04ea6c
Compare
Member
|
Ping from triage |
Member
|
@bors r+ I believe that this documentation is not adding to our stability guarantees as it is explicit about what we guarantee (new fields, new variants can be added). In any case, I consider rustc book to be somewhat non-normative, though maybe this is not true in practice. I think the JSON interface of rustc we are somewhat less likely to care about breaking (since it affects build tools, rather than source code, and less build tools exist). |
Collaborator
|
📌 Commit f04ea6c has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 18, 2019
Document JSON message output. This documents the JSON messages in the rustc book.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 18, 2019
Document JSON message output. This documents the JSON messages in the rustc book.
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 18, 2019
Document JSON message output. This documents the JSON messages in the rustc book.
Collaborator
bors
added a commit
that referenced
this pull request
Oct 18, 2019
Document JSON message output. This documents the JSON messages in the rustc book.
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 18, 2019
Tested on commit rust-lang/rust@518deda. Direct link to PR: <rust-lang/rust#64925> 💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents the JSON messages in the rustc book.