Compute the layout of uninhabited structs#64987
Conversation
rust-highfive
added
the
S-waiting-on-review
| assert!(field < count as u64, | ||
| "Tried to access field {} of union with {} fields", field, count); | ||
| "Tried to access field {} of union {:#?} with {} fields", | ||
| field, base.layout, count); |
There was a problem hiding this comment.
Can you add this assert to FieldPlacement::offset? And even add an offset_u64, if you want (I guess offset(i) can just call offset_u64(i as u64)? or maybe we just want an i: impl Into<u64> on offset).
There was a problem hiding this comment.
u64 does not implement From<usize> :(
|
@bors r+ |
|
📌 Commit 373c362 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 373c362 with merge 2fe9b4b0bf4f8842e26f58d928cf6a5d5153fbfa... |
…=eddyb Compute the layout of uninhabited structs fixes rust-lang#64506 r? @eddyb
|
@bors retry rolled up. |
|
⌛ Testing commit 373c362 with merge 434fcab8166c6478551efb023d412fa6e67b0731... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
@Centril I assume you noticed, but just in case, FYI every single build appears to be failing on a connection error to the azure ubuntu apt repos. |
|
@bors treeclosed=1000 |
|
@bors treeclose=1000 network problems |
|
@bors treeclosed- This build seems to be ok. |
|
☀️ Test successful - checks-azure |
8 participants
fixes #64506
r? @eddyb