Use structured suggestions for missing associated items#65752
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 7, 2019
Merged
Use structured suggestions for missing associated items#65752bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
r? @Centril Looking at the changes one commit at a time will be easier to follow. |
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Oct 24, 2019
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
This is just some initial feedback; I'll look more in-depth later.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
sugg
branch
2 times, most recently
from
f73eb2c to
ab187ba
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Centril
added
S-blocked
Centril
added
S-waiting-on-review
Centril
reviewed
Oct 29, 2019
Centril
added
S-waiting-on-author
estebank
added
S-waiting-on-review
Centril
reviewed
Oct 31, 2019
Contributor
|
r=me with two remaining nits addressed. |
Centril
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@bors r=Centril |
Collaborator
|
📌 Commit a12a32a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit a12a32a with merge 67e714a18f52bd750356eb37155ed35134022025... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 7, 2019
Use structured suggestions for missing associated items When encountering an `impl` that is missing associated items required by its `trait`, use structured suggestions at an appropriate place in the `impl`.
Contributor
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Nov 7, 2019
Rollup of 5 pull requests Successful merges: - #59789 (Revert two unapproved changes to rustc_typeck.) - #65752 (Use structured suggestions for missing associated items) - #65884 (syntax: ABI-oblivious grammar) - #65974 (A scheme for more macro-matcher friendly pre-expansion gating) - #66017 (Add future incompatibility lint for `array.into_iter()`) Failed merges: - #66056 (rustc_metadata: Some reorganization of the module structure) r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering an
implthat is missing associated items required by itstrait, use structured suggestions at an appropriate place in theimpl.