Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
Self-r+ because this just updates a submodule; p=1 because it fixes toolstate. @bors r+ p=1 |
|
📌 Commit aff0b3a3273f4c5011ec8f0d1a4324601c44c1d7 has been approved by |
|
⌛ Testing commit aff0b3a3273f4c5011ec8f0d1a4324601c44c1d7 with merge 219145fcee85fcc925c37bf7c529659b18d90f5d... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-azure |
|
@oli-obk due to rust-lang/miri#1010, bootstrap now has to install xargo itself. I think that's good; it disentangles the two a bit -- bootstrap makes fewer assumptions about what Could you review the changes needed for that? |
|
Heh, neat setup. I'm not sure about the @bors r+ |
|
📌 Commit 0177bc413d4f69c094a3cb7ce1240f37d43bb8e5 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
|
The install directory is also left unchanged by this PR. |
This comment has been minimized.
This comment has been minimized.
|
Hm, looks like we can't call @bors r- |
|
This time I build-tested it... took an hour but now it's looking good. :) @bors r=oli-obk |
|
📌 Commit 1b355b6a2a30ea49f1442c0cd8a6ab3ab33fad97 has been approved by |
|
⌛ Testing commit 1b355b6a2a30ea49f1442c0cd8a6ab3ab33fad97 with merge 2b6d1e0c06aba64a3de525692873dd80424c565c... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Some other PR landed in the mean time that broke Miri: |
|
Rebased and fixed Miri. @bors r=oli-obk |
|
📌 Commit 58da335 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
|
☀️ Test successful - checks-azure |
Tested on commit rust-lang/rust@8318ef2. Direct link to PR: <rust-lang/rust#65758> 🎉 miri on windows: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). 🎉 miri on linux: build-fail → test-pass (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra).
Fixes #65684