Remove PartialEq and Eq from the SpecialDerives.#65892
Merged
bors merged 3 commits intorust-lang:masterfrom Nov 6, 2019
Merged
Remove PartialEq and Eq from the SpecialDerives.#65892bors merged 3 commits intorust-lang:masterfrom
PartialEq and Eq from the SpecialDerives.#65892bors merged 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
varkor
reviewed
Oct 28, 2019
Contributor
|
|
petrochenkov
added
S-waiting-on-author
pnkfelix
added
S-waiting-on-review
Contributor
|
LGTM beside the naming question. |
petrochenkov
added
S-waiting-on-author
Contributor
Author
|
@bors r=petrochenkov rollup |
Collaborator
|
📌 Commit 72eb8a0386e62af970c320cbf28c91a68077a781 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #65835) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
pnkfelix
force-pushed
the
trim-special-derives
branch
from
72eb8a0 to
9924361
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 9924361 has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 5, 2019
…trochenkov Remove `PartialEq` and `Eq` from the `SpecialDerives`. Now that PR rust-lang#65519 landed, this is the follow-on work of removing `PartialEq` and `Eq` from the set of `SpecialDerives` .
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 6, 2019
…trochenkov Remove `PartialEq` and `Eq` from the `SpecialDerives`. Now that PR rust-lang#65519 landed, this is the follow-on work of removing `PartialEq` and `Eq` from the set of `SpecialDerives` .
bors
added a commit
that referenced
this pull request
Nov 6, 2019
Rollup of 11 pull requests Successful merges: - #65892 (Remove `PartialEq` and `Eq` from the `SpecialDerives`.) - #66014 (Show type parameter name and definition in type mismatch error messages ) - #66027 (Move has_panic_handler to query) - #66054 (syntax: Avoid span arithmetic for delimiter tokens) - #66068 (use silent emitter for rustdoc highlighting pass) - #66081 (let caller of check_ptr_access_align control the error message) - #66093 (Do not ICE with a precision flag in formatting str and no format arguments) - #66098 (Detect `::` -> `:` typo when involving turbofish) - #66101 (Tweak type mismatch caused by break on tail expr) - #66106 (Fix typo in explanation of `E0080`) - #66115 (rustc: remove "GlobalMetaData" dead code from hir::map::definitions.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that PR #65519 landed, this is the follow-on work of removing
PartialEqandEqfrom the set ofSpecialDerives.