Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
split-syntax-3
branch
from
ffdb6db to
2ed5bb4
Compare
davidtwco
requested changes
Oct 29, 2019
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
I'd like to see the last commit's changes squashed into the relevant commits that introduced the issues, but otherwise, r=me.
Centril
force-pushed
the
split-syntax-3
branch
from
2ed5bb4 to
27adef6
Compare
Contributor
Author
|
Squashed -- was easier than I feared. :) @bors r=davidtwco |
Collaborator
|
📌 Commit 27adef62d6e8f73e5645eb8ad7f5bbcb9d595122 has been approved by |
bors
added
the
S-waiting-on-bors
Contributor
Author
|
I'm not even going to try getting this through CI now that the toolstate week is in effect. :) @bors r- |
bors
added
S-waiting-on-author
Centril
added
S-blocked
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
split-syntax-3
branch
2 times, most recently
from
2d04b43 to
948674b
Compare
Contributor
Author
|
Toolstate should be breakable again, @bors r=davidtwco |
Collaborator
|
📌 Commit 948674b6e94af25d7c64dbd91ba235467140457a has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
Centril
force-pushed
the
split-syntax-3
branch
from
948674b to
7514dcd
Compare
Contributor
Author
|
@bors r=davidtwco |
Collaborator
|
📌 Commit 7514dcdb8e8cf50a0ca6415d1b513e424b7c3144 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
Centril
force-pushed
the
split-syntax-3
branch
from
fa72c56 to
cc9c139
Compare
Contributor
Author
|
@bors r=davidtwco |
Collaborator
|
📌 Commit cc9c139 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 7, 2019
syntax: move stuff around Part of rust-lang#65324. r? @davidtwco cc @estebank @petrochenkov
bors
added a commit
that referenced
this pull request
Nov 7, 2019
Rollup of 5 pull requests Successful merges: - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore) - #64696 ([rustdoc] add sub settings) - #65916 (syntax: move stuff around) - #66087 (Update some build-pass ui tests to use check-pass where applicable) - #66182 (invalid_value lint: fix help text) Failed merges: r? @ghost
Merged
bors
added a commit
that referenced
this pull request
Nov 7, 2019
Rollup of 5 pull requests Successful merges: - #63793 (Have tidy ensure that we document all `unsafe` blocks in libcore) - #64696 ([rustdoc] add sub settings) - #65916 (syntax: move stuff around) - #66087 (Update some build-pass ui tests to use check-pass where applicable) - #66182 (invalid_value lint: fix help text) Failed merges: r? @ghost
tesuji
added a commit
to tesuji/rust-clippy
that referenced
this pull request
Nov 8, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 8, 2019
rustup rust-lang/rust#65916 cc rust-lang/rust#65916 changelog: none
tesuji
added a commit
to tesuji/rust-clippy
that referenced
this pull request
Nov 8, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Nov 8, 2019
rustup rust-lang/rust#65916 cc rust-lang/rust#65916 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #65324.
r? @davidtwco
cc @estebank @petrochenkov