Add method Result::into_ok

[mzabaluev]

Implementation of rust-lang/rfcs#2799

Tracking issue #61695

[rust-highfive]

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-02T19:55:01.9269595Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-02T19:55:01.9496956Z ##[command]git config gc.auto 0
2019-11-02T19:55:02.9244378Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-02T19:55:02.9251689Z ##[command]git config --get-all http.proxy
2019-11-02T19:55:02.9257650Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66045/merge:refs/remotes/pull/66045/merge
---
2019-11-02T20:01:12.0256749Z Found 0 error codes with no tests
2019-11-02T20:01:12.0257402Z Done!
2019-11-02T20:01:12.0257436Z 
2019-11-02T20:01:12.0257486Z 
2019-11-02T20:01:12.0258285Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-02T20:01:12.0258380Z 
2019-11-02T20:01:12.0258419Z 
2019-11-02T20:01:12.0266522Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-02T20:01:12.0266604Z Build completed unsuccessfully in 0:01:20
2019-11-02T20:01:12.0266604Z Build completed unsuccessfully in 0:01:20
2019-11-02T20:01:12.0310686Z == clock drift check ==
2019-11-02T20:01:12.0322949Z   local time: Sat Nov  2 20:01:12 UTC 2019
2019-11-02T20:01:12.1036837Z   network time: Sat, 02 Nov 2019 20:01:12 GMT
2019-11-02T20:01:12.1041908Z == end clock drift check ==
2019-11-02T20:01:13.5224593Z 
2019-11-02T20:01:13.5328795Z ##[error]Bash exited with code '1'.
2019-11-02T20:01:13.5355489Z ##[section]Starting: Checkout
2019-11-02T20:01:13.5357419Z ==============================================================================
2019-11-02T20:01:13.5357488Z Task         : Get sources
2019-11-02T20:01:13.5357530Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[JohnCSimon]

Ping from triage:
@sfackler Can you please review this PR?
CC: @mzabaluev

Thanks!

[sfackler]

@rfcbot fcp merge

[rfcbot]

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @Kimundi
• @KodrAus
• @SimonSapin
• @alexcrichton
• @dtolnay
• @sfackler
• @withoutboats

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[JohnCSimon]

Ping from triage - this PR is still waiting on review:
cc: @Kimundi @KodrAus @SimonSapin @sfackler @mzabaluev
Thanks.

[SimonSapin]

I’ve changed the PR description to not close #61695 since that is to become the tracking issue.

[JohnCSimon]

Ping from triage - @sfackler this looks like it's still waiting on a merge

[sfackler]

It is still waiting on one of @Kimundi, @KodrAus, or @withoutboats to complete the FCP process.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

[sfackler]

@bors r+

[bors]

📌 Commit 6f6848f has been approved by sfackler

[bors]

⌛ Testing commit 6f6848f with merge cf5afc8...

[rust-highfive]

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-10T06:45:51.2672888Z   local time: Tue Dec 10 06:45:51 UTC 2019
2019-12-10T06:45:51.4070172Z   network time: Tue, 10 Dec 2019 06:45:51 GMT
2019-12-10T06:45:51.4073322Z == end clock drift check ==
2019-12-10T06:45:51.8296195Z 
2019-12-10T06:45:51.8376250Z ##[error]Bash exited with code '1'.
2019-12-10T06:45:51.8421090Z ##[section]Starting: Checkout
2019-12-10T06:45:51.8422650Z ==============================================================================
2019-12-10T06:45:51.8422740Z Task         : Get sources
2019-12-10T06:45:51.8422805Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[bors]

💔 Test failed - checks-azure

[mzabaluev]

never_type has been stabilized since this branch was first submitted. I have rebased and removed the feature(never_type) crate attributes from tests.

[KodrAus]

@bors retry

[MikailBag]

Probably it is too late for changes, but I think feature should be renamed too (e.g. to result_into_ok).

[bors]

☔ The latest upstream changes (presumably #67485) made this pull request unmergeable. Please resolve the merge conflicts.

[mzabaluev]

The rebased branch is mergeable and the code currently compiles. Does anything else need to be done to remove S-waiting-on-author?

[dtolnay]

@bors r+

[bors]

📌 Commit 6f0672c has been approved by dtolnay