Conversation
GuillaumeGomez
force-pushed
the
no-more-hidden-elements
branch
from
2b37a6f to
f66a331
Compare
|
r? @Dylan-DPC |
| function isHidden(elem) { | ||
| return elem.offsetHeight === 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
This function seems odd to have, there's code further down which called an isHidden() function you don't appear to have removed, so is this shadowing one?
There was a problem hiding this comment.
You're absolutely right! I removed the old one.
src/librustdoc/html/static/main.js
Outdated
| handleHashes(); | ||
| highlightSourceLines(); |
There was a problem hiding this comment.
Would it be more future-proof to just call onHashChange() here?
There was a problem hiding this comment.
Took me a while to think about it but I think you're right. I updated the code. Thanks!
hdhoang
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
no-more-hidden-elements
branch
from
bf2b270 to
d4527b7
Compare
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
Looks good to me. I've not confirmed behaviour because I'm in the middle of a different issue, but it seems sensible by inspection.
|
Then let's wait for your confirmation. :) |
|
looks good to me, ping me when ready to merge |
|
Can confirm functioning. |
|
@bors r+ rollup |
|
📌 Commit d4527b7 has been approved by |
bors
added
S-waiting-on-bors
…nts, r=Dylan-DPC No more hidden elements Fixes rust-lang#66046. Follow-up of rust-lang#66082. r? @kinnison
Rollup of 8 pull requests Successful merges: - #65554 (Enhance the documentation of BufReader for potential data loss) - #65580 (Add `MaybeUninit` methods `uninit_array`, `slice_get_ref`, `slice_get_mut`) - #66049 (consistent handling of missing sysroot spans) - #66056 (rustc_metadata: Some reorganization of the module structure) - #66123 (No more hidden elements) - #66157 (Improve math log documentation examples) - #66165 (Ignore these tests ,since the called commands doesn't exist in VxWorks) - #66190 (rustc_target: inline abi::FloatTy into abi::Primitive.) Failed merges: - #66188 (`MethodSig` -> `FnSig` & Use it in `ItemKind::Fn`) r? @ghost
5 participants
Fixes #66046.
Follow-up of #66082.
r? @kinnison