Skip to content

Point at opaque and closure type definitions in type errors#66463

Merged
bors merged 8 commits intorust-lang:masterfrom
estebank:point-at-closure-and-opaque-types
Jan 10, 2020
Merged

Point at opaque and closure type definitions in type errors#66463
bors merged 8 commits intorust-lang:masterfrom
estebank:point-at-closure-and-opaque-types

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Nov 16, 2019 •
edited
Loading

Fixes #57266, fixes #67117.

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2019
@estebank estebank changed the title Point at opaque and closure type definitions in type errors [WIP] Point at opaque and closure type definitions in type errors Nov 16, 2019
@estebank

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Nov 16, 2019
View reviewed changes
@Centril
Copy link
Contributor

Centril commented Nov 16, 2019

r? @Centril

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@bors

This comment has been minimized.

Sign in to view
@JohnCSimon

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@Aaron1011 Aaron1011 mentioned this pull request Dec 11, 2019
Closed
@hdhoang hdhoang added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 12, 2019
@estebank

This comment has been minimized.

Sign in to view
@estebank estebank changed the title [WIP] Point at opaque and closure type definitions in type errors Point at opaque and closure type definitions in type errors Dec 15, 2019
@estebank estebank force-pushed the point-at-closure-and-opaque-types branch 2 times, most recently from f0219b0 to bbab797 Compare December 16, 2019 06:20
Centril
Centril reviewed Dec 16, 2019
View reviewed changes
@estebank estebank force-pushed the point-at-closure-and-opaque-types branch from 4ebcc3f to 6678094 Compare December 16, 2019 19:44
@bors

This comment has been minimized.

Sign in to view
Aaron1011
Aaron1011 reviewed Jan 1, 2020
View reviewed changes
src/test/ui/impl-trait/equality2.stderr Outdated
Copy link
Contributor

@Aaron1011 Aaron1011 Jan 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to add an additional explanation when the mismatch is due to the substs of an opaque type, as the current message seems quite self-contradictory. Maybe something like:

the expected opaque type (created from foo::<u32>)
the found opaque type (created from foo::<i32>)
note: a distinct opaque type is created for each distinct set of generic arguments provided to `foo`

Copy link
Contributor Author

@estebank estebank Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about how to properly tackle this case. It is certainly confusing, but I would like to tackle it specifically and not as part of this PR. Would you mind filing a follow up ticket for this with your thoughts, @Aaron1011?

I think the wording you present is reasonable, but might require some tweaking, as the created from foo::<_> messages might be hard to accomplish.

Copy link
Contributor

@Aaron1011 Aaron1011 Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #68020

@estebank estebank force-pushed the point-at-closure-and-opaque-types branch from 6678094 to 3efc92a Compare January 8, 2020 00:58
Centril
Centril reviewed Jan 8, 2020
View reviewed changes
Centril
Centril reviewed Jan 8, 2020
View reviewed changes
@bors

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the point-at-closure-and-opaque-types branch from 0c03db6 to 33ae322 Compare January 8, 2020 17:30
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2020
@estebank
Copy link
Contributor Author

estebank commented Jan 8, 2020 •
edited
Loading

Addressed the comments and rebased.

@Aaron1011 Aaron1011 mentioned this pull request Jan 8, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Jan 9, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 9, 2020

📌 Commit 33ae322 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
@Centril
Rollup merge of rust-lang#66463 - estebank:point-at-closure-and-opaqu…
fd9991c 
…e-types, r=Centril

Point at opaque and closure type definitions in type errors

Fixes rust-lang#57266, fixes rust-lang#67117.
@Centril Centril mentioned this pull request Jan 10, 2020
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
@Centril
Rollup merge of rust-lang#66463 - estebank:point-at-closure-and-opaqu…
aabb037 
…e-types, r=Centril

Point at opaque and closure type definitions in type errors

Fixes rust-lang#57266, fixes rust-lang#67117.
@Centril Centril mentioned this pull request Jan 10, 2020
Merged
bors added a commit that referenced this pull request Jan 10, 2020
@bors
Auto merge of #68078 - Centril:rollup-qvq052k, r=Centril
2d8d559 
Rollup of 6 pull requests

Successful merges:

 - #66463 (Point at opaque and closure type definitions in type errors)
 - #67501 (Reduce special treatment for zsts)
 - #67820 (Parse the syntax described in RFC 2632)
 - #67922 (rustc_ast_lowering: misc cleanup & rustc dep reductions)
 - #68071 (Extend support of `_` in type parameters)
 - #68073 (expect `fn` after `const unsafe` / `const extern`)

Failed merges:

r? @ghost
@bors bors merged commit 33ae322 into rust-lang:master Jan 10, 2020
@pnkfelix pnkfelix mentioned this pull request Feb 20, 2020
Closed
@nellshamrell nellshamrell mentioned this pull request Jan 10, 2021
Closed
@estebank estebank deleted the point-at-closure-and-opaque-types branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Centril Centril Centril left review comments

@Aaron1011 Aaron1011 Aaron1011 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Centril Centril

Labels

A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Print better auto-trait diagnostics when opaque return type is involved Error message for type mismatch between impl Traits needs better explanation

8 participants

@estebank @rust-highfive @Centril @bors @JohnCSimon @Aaron1011 @hdhoang @petrochenkov