Skip to content

Add some comments to panic runtime#66694

Merged
bors merged 3 commits intorust-lang:masterfrom
RalfJung:panic-comments
Nov 25, 2019
Merged

Add some comments to panic runtime#66694
bors merged 3 commits intorust-lang:masterfrom
RalfJung:panic-comments

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Nov 24, 2019

No description provided.

@rust-highfive
Copy link
Contributor

rust-highfive commented Nov 24, 2019

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2019
RalfJung
RalfJung commented Nov 24, 2019
View reviewed changes
src/libcore/panicking.rs Outdated
//! ```
//! # use std::fmt;
//! fn panic_impl(fmt: fmt::Arguments, file_line_col: &(&'static str, u32, u32)) -> !
//! fn panic_impl(pi: &PanicInfo<'_>) -> !
Copy link
Member Author

@RalfJung RalfJung Nov 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cc #66689 -- this is a minimal fix, but I am not sure if the comment further down is still accurate. There is still no Box<Any> but there is an &Any that can be passed in.

@RalfJung
Copy link
Member Author

RalfJung commented Nov 24, 2019

r? @alexcrichton

@rust-highfive
Copy link
Contributor

rust-highfive commented Nov 24, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-11-24T10:28:37.7366473Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-24T10:28:37.7579027Z ##[command]git config gc.auto 0
2019-11-24T10:28:38.3267617Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-24T10:28:38.3273943Z ##[command]git config --get-all http.proxy
2019-11-24T10:28:38.3281280Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66694/merge:refs/remotes/pull/66694/merge
---
2019-11-24T11:28:25.4372176Z .................................................................................................... 1600/9282
2019-11-24T11:28:30.2107533Z .................................................................................................... 1700/9282
2019-11-24T11:28:43.2010315Z .............................i...................................................................... 1800/9282
2019-11-24T11:28:49.9013274Z .................................................................................................... 1900/9282
2019-11-24T11:29:03.8720246Z ..............iiiii................................................................................. 2000/9282
2019-11-24T11:29:13.3967668Z .................................................................................................... 2200/9282
2019-11-24T11:29:15.8645788Z .................................................................................................... 2300/9282
2019-11-24T11:29:21.0335313Z .................................................................................................... 2400/9282
2019-11-24T11:29:42.2292691Z .................................................................................................... 2500/9282
---
2019-11-24T11:32:20.7894976Z ..............i...............i..................................................................... 4800/9282
2019-11-24T11:32:31.0821684Z .................................................................................................... 4900/9282
2019-11-24T11:32:36.8102886Z .................................................................................................... 5000/9282
2019-11-24T11:32:46.3067015Z .................................................................................................... 5100/9282
2019-11-24T11:32:52.3516138Z ...................ii.ii...........i................................................................ 5200/9282
2019-11-24T11:33:01.4535584Z .................................................................................................... 5400/9282
2019-11-24T11:33:12.4400312Z .................................................................................................... 5500/9282
2019-11-24T11:33:20.1395110Z .i.................................................................................................. 5600/9282
2019-11-24T11:33:25.6219058Z .................................................................................................... 5700/9282
2019-11-24T11:33:25.6219058Z .................................................................................................... 5700/9282
2019-11-24T11:33:35.9332630Z .......................................................................................ii...i..ii... 5800/9282
2019-11-24T11:33:58.5735293Z .................................................................................................... 6000/9282
2019-11-24T11:34:06.5596435Z .................................................................................................... 6100/9282
2019-11-24T11:34:14.5921079Z .................................................................................................... 6200/9282
2019-11-24T11:34:14.5921079Z .................................................................................................... 6200/9282
2019-11-24T11:34:27.9755811Z ..........i..ii..................................................................................... 6300/9282
2019-11-24T11:34:46.9317963Z ..............................................................................i..................... 6500/9282
2019-11-24T11:34:49.2928700Z .................................................................................................... 6600/9282
2019-11-24T11:34:51.5498425Z .....................................................................i.............................. 6700/9282
2019-11-24T11:34:54.4783963Z .................................................................................................... 6800/9282
---
2019-11-24T11:40:04.0272901Z  finished in 5.964
2019-11-24T11:40:04.0472736Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T11:40:04.2466655Z 
2019-11-24T11:40:04.2471870Z running 157 tests
2019-11-24T11:40:07.1488787Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/157
2019-11-24T11:40:09.1487837Z .i.i..iiii..............i.........iii.i..........ii......
2019-11-24T11:40:09.1490233Z 
2019-11-24T11:40:09.1492784Z  finished in 5.102
2019-11-24T11:40:09.1671460Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T11:40:09.3417764Z 
---
2019-11-24T11:40:11.3227675Z  finished in 2.155
2019-11-24T11:40:11.3411681Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T11:40:11.5123203Z 
2019-11-24T11:40:11.5124984Z running 9 tests
2019-11-24T11:40:11.5126003Z iiiiiiiii
2019-11-24T11:40:11.5126588Z 
2019-11-24T11:40:11.5126630Z  finished in 0.171
2019-11-24T11:40:11.5323018Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T11:40:11.7229696Z 
---
2019-11-24T11:40:31.0417790Z  finished in 19.509
2019-11-24T11:40:31.0757790Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T11:40:31.2683898Z 
2019-11-24T11:40:31.2685250Z running 124 tests
2019-11-24T11:40:56.4185401Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i....ii...i.......ii 100/124
2019-11-24T11:41:01.7096731Z .i.i.i......iii.i.....ii
2019-11-24T11:41:01.7100041Z 
2019-11-24T11:41:01.7100776Z  finished in 30.634
2019-11-24T11:41:01.7108874Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T11:41:01.7109730Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-11-24T11:53:05.3084917Z 
2019-11-24T11:53:05.3086774Z    Doc-tests core
2019-11-24T11:53:10.3379035Z 
2019-11-24T11:53:10.3380100Z running 2421 tests
2019-11-24T11:53:20.7196859Z ......iiiii......................................................................................... 100/2421
2019-11-24T11:53:42.7439094Z .................................................................................................... 300/2421
2019-11-24T11:53:54.9117334Z ..i................................................................................................. 400/2421
2019-11-24T11:53:54.9117334Z ..i................................................................................................. 400/2421
2019-11-24T11:54:04.9892695Z ..................................................i..i..................iiii........................ 500/2421
2019-11-24T11:54:23.7741456Z .................................................................................................... 700/2421
2019-11-24T11:54:33.6536284Z .................................................................................................... 800/2421
2019-11-24T11:54:43.5462521Z .................................................................................................... 900/2421
2019-11-24T11:54:53.4132918Z .................................................................................................... 1000/2421
---
2019-11-24T11:57:20.4795090Z ---- panicking.rs - panicking (line 8) stdout ----
2019-11-24T11:57:20.4795203Z error[E0412]: cannot find type `PanicInfo` in this scope
2019-11-24T11:57:20.4795421Z  --> panicking.rs:10:20
2019-11-24T11:57:20.4795463Z   |
2019-11-24T11:57:20.4795668Z 5 | fn panic_impl(pi: &PanicInfo<'_>) -> !
2019-11-24T11:57:20.4796005Z   |
2019-11-24T11:57:20.4796052Z help: possible candidates are found in other modules, you can import them into scope
2019-11-24T11:57:20.4796112Z   |
2019-11-24T11:57:20.4796151Z 3 | use core::panic::PanicInfo;
---
2019-11-24T11:57:20.4943703Z   local time: Sun Nov 24 11:57:20 UTC 2019
2019-11-24T11:57:20.7740364Z   network time: Sun, 24 Nov 2019 11:57:20 GMT
2019-11-24T11:57:20.7745379Z == end clock drift check ==
2019-11-24T11:57:21.3129397Z 
2019-11-24T11:57:21.3248721Z ##[error]Bash exited with code '1'.
2019-11-24T11:57:21.3292873Z ##[section]Starting: Checkout
2019-11-24T11:57:21.3294779Z ==============================================================================
2019-11-24T11:57:21.3294833Z Task         : Get sources
2019-11-24T11:57:21.3294882Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Nov 24, 2019

r? @Dylan-DPC

@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Nov 24, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 24, 2019

📌 Commit 6440b94 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Nov 25, 2019
@emilyalbini
Rollup merge of rust-lang#66694 - RalfJung:panic-comments, r=Dylan-DPC
8480a78 
Add some comments to panic runtime
@emilyalbini emilyalbini mentioned this pull request Nov 25, 2019
Closed
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Nov 25, 2019
@emilyalbini
Rollup merge of rust-lang#66694 - RalfJung:panic-comments, r=Dylan-DPC
30599d7 
Add some comments to panic runtime
@emilyalbini emilyalbini mentioned this pull request Nov 25, 2019
Merged
bors added a commit that referenced this pull request Nov 25, 2019
@bors
Auto merge of #66739 - pietroalbini:rollup-2t2pd4a, r=pietroalbini
a44774c 
Rollup of 7 pull requests

Successful merges:

 - #65613 (Preserve whitespace inside one-backtick codeblocks)
 - #66512 (Add unix::process::CommandExt::arg0)
 - #66569 (GitHub Actions: preparations, part 1)
 - #66678 (Remove useless line for error index generation)
 - #66684 (Drive-by cleanup in region naming)
 - #66694 (Add some comments to panic runtime)
 - #66698 (tidy: Remove unused import)

Failed merges:

r? @ghost
@bors bors merged commit 6440b94 into rust-lang:master Nov 25, 2019
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung @rust-highfive @Dylan-DPC-zz @bors @alexcrichton @Kimundi