Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
cc @estebank |
This comment has been minimized.
This comment has been minimized.
petrochenkov
reviewed
Dec 6, 2019
petrochenkov
added
S-waiting-on-author
Centril
added
S-waiting-on-review
Contributor
Author
|
@petrochenkov Addressed the review comments. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 99191c2 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 6, 2019
Ditch `parse_in_attr` Fixes rust-lang#66940 r? @petrochenkov
bors
added a commit
that referenced
this pull request
Dec 6, 2019
Rollup of 10 pull requests Successful merges: - #66606 (Add feature gate for mut refs in const fn) - #66841 (Add `{f32,f64}::approx_unchecked_to<Int>` unsafe methods) - #67009 (Emit coercion suggestions in more places) - #67052 (Ditch `parse_in_attr`) - #67071 (Do not ICE on closure typeck) - #67078 (accept union inside enum if not followed by identifier) - #67090 (Change "either" to "any" in Layout::from_size_align's docs) - #67092 (Fix comment typos in src/libcore/alloc.rs) - #67094 (get rid of __ in field names) - #67102 (Add note to src/ci/docker/README.md about multiple docker images) Failed merges: - #67101 (use `#[allow(unused_attributes)]` to paper over incr.comp problem) r? @ghost
estebank
reviewed
Dec 9, 2019
| --> $DIR/cfg-attr-parse.rs:50:18 | ||
| | | ||
| LL | #[cfg_attr{all(),,}] | ||
| | ^ expected identifier |
Contributor
There was a problem hiding this comment.
From personal experience trailing commas seems like a good case to account for in the parser, in the same way we account for extra and missing semicolons. What do you think?
Contributor
Author
There was a problem hiding this comment.
If you use the standard list parsers then it is handled automatically, and otherwise it's not worth it I'd say.
estebank
reviewed
Dec 9, 2019
| | | ||
| LL | #[derive(Copy="bad")] | ||
| | ^ expected one of `)`, `,`, or `::` | ||
| | ^^^^^^ help: remove the value |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 28, 2020
error_derive_forbidden_on_non_adt: be more graceful Fixes rust-lang#69341 which was injected by rust-lang#67052. r? @petrochenkov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66940
r? @petrochenkov