Merged
Conversation
We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
Contributor
|
Let's rubber-stamp & see if it fixes things. @bors r+ rollup |
Collaborator
|
📌 Commit 1787b2b has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 19, 2019
…ntril Fix toolstate history format We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 19, 2019
…ntril Fix toolstate history format We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 19, 2019
…ntril Fix toolstate history format We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Dec 19, 2019
…ntril Fix toolstate history format We were inserting *before* the existing newline, so we should prepend it not append it to our inserted string.
bors
added a commit
that referenced
this pull request
Dec 19, 2019
Rollup of 6 pull requests Successful merges: - #67253 (Add more delegations to the fmt docs and add doctests) - #67281 (add string.insert benchmarks) - #67351 (Set release channel on non-dist builders) - #67421 (Fix internal documentation typo) - #67432 (Fix toolstate history format) - #67436 (Correct the todo! stabilization version) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were inserting before the existing newline, so we should prepend it
not append it to our inserted string.