rustdoc: improve stability mark arrows#67959
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 13, 2020
Merged
Conversation
Contributor
Author
|
cc #51387 |
JohnTitor
added
the
S-waiting-on-review
GuillaumeGomez
requested changes
Jan 7, 2020
Member
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Just one change to make, otherwise looks good to me.
Member
There was a problem hiding this comment.
Everything color-linked should be put inside light.css and dark.css files (even if it's the same in both files.
Contributor
Author
|
@GuillaumeGomez done. |
Member
There was a problem hiding this comment.
Also I'm not a fan of this. I'm pretty sure the expected character exists as is.
Contributor
Author
There was a problem hiding this comment.
I failed to find it. Will check that again.
Contributor
Author
There was a problem hiding this comment.
changed to another arrow: ⬑
Contributor
Author
|
Now we use the 'Leftwards Arrow with Tip Upwards': ⬑ (U+2B11)
|
Member
|
Thanks a lot! @bors: r+ rollup |
Collaborator
|
📌 Commit ae3a53f has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 11, 2020
rustdoc: improve stability mark arrows ### current  ### new  ### new dark 
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 12, 2020
rustdoc: improve stability mark arrows ### current  ### new  ### new dark 
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 12, 2020
rustdoc: improve stability mark arrows ### current  ### new  ### new dark 
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 13, 2020
rustdoc: improve stability mark arrows ### current  ### new  ### new dark 
bors
added a commit
that referenced
this pull request
Jan 13, 2020
Rollup of 8 pull requests Successful merges: - #67313 (Document more use cases of dataflow) - #67959 (rustdoc: improve stability mark arrows) - #68097 (Specify units for test timeout environment variables) - #68135 (restore some rustc_parse visibilities for rustfmt) - #68145 (Expose `context::CheckLintNameResult`) - #68156 (Fix crate paths in comments) - #68157 (Clean up E0186 explanation) - #68161 (Fix system call docs for time::Instant) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current
new
new dark