Add llvm-skip-rebuild flag to x.py#68074
Merged
bors merged 3 commits intorust-lang:masterfrom Jan 11, 2020
matthew-healy:skip-llvm-rebuild-option
Merged
Add llvm-skip-rebuild flag to x.py#68074bors merged 3 commits intorust-lang:masterfrom matthew-healy:skip-llvm-rebuild-option
llvm-skip-rebuild flag to x.py#68074bors merged 3 commits intorust-lang:masterfrom
matthew-healy:skip-llvm-rebuild-option
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Jan 10, 2020
Contributor
|
r? @Centril r=me with comment ^-- addressed. |
Author
|
@Centril Thanks for the review! I've updated the PR. I also added a |
Contributor
|
It's not something we typically do, but it also seems fine to me. :) @bors r+ |
Collaborator
|
📌 Commit 7e50b59 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 11, 2020
…ion, r=Centril Add `llvm-skip-rebuild` flag to `x.py` This PR follows on from rust-lang#67437 to complete the feature request from rust-lang#65612. Specifically it adds a new command-line flag, `--llvm-skip-rebuild`, which overrides both any value set in `config.toml` and the default value (`false`). I'm not 100% confident that I've implemented the override in the "best" way, but I've checked it locally and it seems to work at least. This option isn't currently mentioned in the Guide to Rustc Development. I'd be happy to write something on it if folk think that's worthwhile.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 11, 2020
…ion, r=Centril Add `llvm-skip-rebuild` flag to `x.py` This PR follows on from rust-lang#67437 to complete the feature request from rust-lang#65612. Specifically it adds a new command-line flag, `--llvm-skip-rebuild`, which overrides both any value set in `config.toml` and the default value (`false`). I'm not 100% confident that I've implemented the override in the "best" way, but I've checked it locally and it seems to work at least. This option isn't currently mentioned in the Guide to Rustc Development. I'd be happy to write something on it if folk think that's worthwhile.
bors
added a commit
that referenced
this pull request
Jan 11, 2020
Rollup of 8 pull requests Successful merges: - #67666 (make use of pointer::is_null) - #67806 (Extract `rustc_ast_passes`, move gating, & refactor linting) - #68043 (Add some missing timers) - #68074 (Add `llvm-skip-rebuild` flag to `x.py`) - #68079 (Clarify suggestion for E0013) - #68084 (Do not ICE on unicode next point) - #68102 (Inline some conversion methods around OsStr) - #68106 (Fix issue with using `self` module via indirection) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows on from #67437 to complete the feature request from #65612.
Specifically it adds a new command-line flag,
--llvm-skip-rebuild, which overrides both any value set inconfig.tomland the default value (false).I'm not 100% confident that I've implemented the override in the "best" way, but I've checked it locally and it seems to work at least.
This option isn't currently mentioned in the Guide to Rustc Development. I'd be happy to write something on it if folk think that's worthwhile.