Skip to content

Make pointers to statics internal#68494

Merged
bors merged 1 commit intorust-lang:masterfrom
matthewjasper:internal-static-ptrs
Jan 24, 2020
Merged

Make pointers to statics internal#68494
bors merged 1 commit intorust-lang:masterfrom
matthewjasper:internal-static-ptrs

Conversation

@matthewjasper
Copy link
Contributor

@matthewjasper matthewjasper commented Jan 23, 2020

Closes #67611

r? @nikomatsakis

@matthewjasper matthewjasper added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 23, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2020
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 23, 2020
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 23, 2020

If this is to get into beta, then it needs to be approved ASAP; release week is next week. cc @pnkfelix @nikomatsakis

@rust-highfive

This comment has been minimized.

Sign in to view
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 23, 2020

@matthewjasper test failures

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jan 23, 2020
Merged
@matthewjasper
Copy link
Contributor Author

matthewjasper commented Jan 24, 2020

Tests are passing now.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 24, 2020

@bors r+p=1

I'm going to go ahead and r+ this because I think it's imporant to fix the regression in a timely fashion. There is room to revisit the mechanism and/or discuss in more depth going forward.

(In particular, I'm not trying to shortcircuit lang or other discussion.)

@nikomatsakis nikomatsakis mentioned this pull request Jan 24, 2020
Closed
@emilyalbini
Copy link
Member

emilyalbini commented Jan 24, 2020

@bors r=nikomatsakis p=1

@bors
Copy link
Collaborator

bors commented Jan 24, 2020

📌 Commit f30a818 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2020
bors added a commit that referenced this pull request Jan 24, 2020
@bors
Auto merge of #68494 - matthewjasper:internal-static-ptrs, r=nikomats…
c2d141d 
…akis

Make pointers to statics internal

Closes #67611

r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Jan 24, 2020

⌛ Testing commit f30a818 with merge c2d141d...

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 24, 2020
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 24, 2020

Dear @rust-lang/compiler -- I'm taking the liberty of marking this regression as "beta-accepted" all on my own, because it's Friday and shortly before release. Please feel free to object.

@bors
Copy link
Collaborator

bors commented Jan 24, 2020

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing c2d141d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 24, 2020
@bors bors merged commit f30a818 into rust-lang:master Jan 24, 2020
@matthewjasper matthewjasper deleted the internal-static-ptrs branch January 24, 2020 20:48
@emilyalbini emilyalbini mentioned this pull request Jan 27, 2020
Merged
@emilyalbini emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 27, 2020
bors added a commit that referenced this pull request Jan 27, 2020
@bors
Auto merge of #68568 - pietroalbini:stable-next, r=pietroalbini
5e1a799 
[stable] Rust 1.41.0 stable release

This PR produces the 1.41.0 stable release, backporting the following PRs as well:

* #68494: Make pointers to statics internal
* #67928: Update RELEASES.md for 1.41.0

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

not Send due to await retainment

7 participants

@matthewjasper @Mark-Simulacrum @rust-highfive @nikomatsakis @emilyalbini @bors @jonas-schievink