Merged
Conversation
This commit adds guidance for when a user means to type a path, but ends up typing a single colon, such as `<<Impl as T>:Ty>`. This change seemed pertinent as the current error message is particularly misleading, emitting `error: unmatched angle bracket`, despite the angle bracket being matched later on, leaving the user to track down the typo'd colon.
rustc is now using rustfmt, not the old formatter.
`AllocRef` was reexported as `Alloc` in order to not break toolstate in the week before the next stable release.
…mulacrum Use BufWriter for emitting MIR I noticed that `--emit=mir` takes long time on a large crate. rust-lang#64344 seem to have fixed `-Zdump-mir`, but not `--emit=mir`.
…ets, r=Centril Suggest path separator for single-colon typos This commit adds guidance for when a user means to type a path, but ends up typing a single colon, such as `<<Impl as T>:Ty>`. This change seemed pertinent as the current error message is particularly misleading, emitting `error: unmatched angle bracket`, despite the angle bracket being matched later on, leaving the user to track down the typo'd colon.
…if-on-nightly, r=centril [docs] remind bug reporters to update nightly Hi and thanks for rust! Today I reported a bug in nightly that was already fixed, so I thought other potential bug reporters might appreciate a reminder to update before reporting. I wasn't sure if this would apply for other channels as well.
…=Mark-Simulacrum Ignore `build` dir formatting I've noticed that rustfmt tries to parse and check the formatting of code in `build` if `.git` is missing (which includes test artifacts and generated code). This should fix that.
…inter-in-format-tests, r=jonas-schievink Remove a comment about pretty printer in formatting tests rustc is now using rustfmt, not the old formatter.
Remove `Alloc` in favor of `AllocRef` `AllocRef` was reexported as `Alloc` in rust-lang#68529 in order to not break toolstate in the week before the next stable release. r? @Amanieu
…=Centril Do not suggest things named underscore Fixes rust-lang#68719 r? @estebank
Member
Author
|
@bors r+ p=7 rollup=never |
Collaborator
|
📌 Commit 87bb0c4 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Feb 1, 2020
Rollup of 7 pull requests Successful merges: - #68460 (Use BufWriter for emitting MIR) - #68681 (Suggest path separator for single-colon typos) - #68688 ([docs] remind bug reporters to update nightly) - #68704 (Ignore `build` dir formatting) - #68727 (Remove a comment about pretty printer in formatting tests) - #68736 (Remove `Alloc` in favor of `AllocRef`) - #68740 (Do not suggest things named underscore) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-azure |
Contributor
|
📣 Toolstate changed by #68752! Tested on commit e5b150e. 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 2, 2020
Tested on commit rust-lang/rust@e5b150e. Direct link to PR: <rust-lang/rust#68752> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung, @rust-lang/infra). 💔 nomicon on windows: test-pass → test-fail (cc @Gankra @frewsxcv, @rust-lang/infra). 💔 nomicon on linux: test-pass → test-fail (cc @Gankra @frewsxcv, @rust-lang/infra). 💔 rustc-guide on linux: test-pass → test-fail (cc @JohnTitor @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
builddir formatting #68704 (Ignorebuilddir formatting)Allocin favor ofAllocRef#68736 (RemoveAllocin favor ofAllocRef)Failed merges:
r? @ghost